Skip to content

[google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

[google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type #9720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7345fee
[google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast deprecat…
jmagman Aug 1, 2025
fda4e7f
Format
jmagman Aug 1, 2025
af1cf5c
test
jmagman Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.15.5

* Fixes `kCGImageAlphaPremultipliedLast` implicit conversion from enumeration type warning.
Copy link

@gemini-code-assist gemini-code-assist bot Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Per the repository's contribution guide1, which specifies the CHANGELOG style, entries should be in the past tense and be a complete sentence ending with a period. Please update this entry to align with the guide.

Style Guide References

Suggested change
* Fixes `kCGImageAlphaPremultipliedLast` implicit conversion from enumeration type warning.
* Fixed `kCGImageAlphaPremultipliedLast` implicit conversion from enumeration type warning.

Footnotes

  1. PR descriptions should include the Pre-Review Checklist from the PR template, with all of the steps completed. (link) ↩

Copy link
Member Author

@jmagman jmagman Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This advice is wrong, the CHANGELOG style says:

Entries should use present tense indicative for verbs, with "this version" as an implied subject. For example, "Adds cool new feature.", not "Add", "Added", or "Adding".


## 2.15.4

* Deprecates `zIndex` parameter in Marker in favor of `zIndexInt`.
Expand Down
3 changes: 2 additions & 1 deletion ...ogle_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ - (void)testHandleResultTileDownsamplesWideGamutImages {
size_t bitsPerComponent = CGImageGetBitsPerComponent(imageRef);

// non wide gamut images use 8 bit format
XCTAssert(bitsPerComponent == 8);
XCTAssertEqual(bitsPerComponent, 8);
XCTAssertEqual(CGImageGetAlphaInfo(imageRef), kCGImageAlphaPremultipliedLast);
}

- (void)testAnimateCameraWithUpdate {
Expand Down
5 changes: 3 additions & 2 deletions ...ogle_maps_flutter/google_maps_flutter_ios/ios/Classes/FLTGoogleMapTileOverlayController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ - (UIImage *)handleResultTile:(nullable UIImage *)tile {
// If it is wide gamut, we want to downsample it
if (isFloat & (bitsPerComponent == 16)) {
CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
CGContextRef context = CGBitmapContextCreate(nil, tile.size.width, tile.size.height, 8, 0,
colorSpace, kCGImageAlphaPremultipliedLast);
CGContextRef context =
CGBitmapContextCreate(nil, tile.size.width, tile.size.height, 8, 0, colorSpace,
(kCGBitmapAlphaInfoMask & kCGImageAlphaPremultipliedLast));
CGContextDrawImage(context, CGRectMake(0, 0, tile.size.width, tile.size.height), tile.CGImage);
CGImageRef image = CGBitmapContextCreateImage(context);
tile = [UIImage imageWithCGImage:image];
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter_ios/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter_ios
description: iOS implementation of the google_maps_flutter plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.15.4
version: 2.15.5

environment:
sdk: ^3.6.0
Expand Down