[interactive_media_ads]: Adds additional methods to configure ad requests #9696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several new properties to AdsRequest to align with the native IMA SDKs. The changes are well-structured and propagated through the platform interface to the Android and iOS implementations, with corresponding test updates.
My review identified a critical race condition in the Android implementation where the ad request could be sent before all its properties are set. I also found a related flaw in the Android test which incorrectly uses verifyInOrder for parallel operations. The iOS implementation and its tests are correct. I've provided suggestions to fix these issues.
The code otherwise adheres to the Flutter Packages Style Guide and follows Effective Dart conventions.
bparrishMines
changed the title
bparrishMines
changed the title
bparrishMines
changed the title
bparrishMines
changed the title
| double? contentDuration, | ||
| List<String>? contentKeywords, | ||
| String? contentTitle, | ||
| double? liveStreamPrefetchSeconds, |
Collaborator
There was a problem hiding this comment.
Why not a Duration??
| double? contentDuration, | ||
| List<String>? contentKeywords, | ||
| String? contentTitle, | ||
| double? liveStreamPrefetchSeconds, |
| bool? adWillAutoPlay, | ||
| bool? adWillPlayMuted, | ||
| bool? continuousPlayback, | ||
| double? contentDuration, |
Collaborator
There was a problem hiding this comment.
Duration??
(If these stay doubles rather than Durations, this one needs a unit naming too.
| bool? adWillAutoPlay, | ||
| bool? adWillPlayMuted, | ||
| bool? continuousPlayback, | ||
| double? contentDuration, |
| List<String>? contentKeywords, | ||
| String? contentTitle, | ||
| double? liveStreamPrefetchSeconds, | ||
| double? vastLoadTimeout, |
Collaborator
There was a problem hiding this comment.
This should also be a Duration? if possible. Especially since the units are different.
| List<String>? contentKeywords, | ||
| String? contentTitle, | ||
| double? liveStreamPrefetchSeconds, | ||
| double? vastLoadTimeout, |
| bool? adWillAutoPlay, | ||
| bool? adWillPlayMuted, | ||
| bool? continuousPlayback, | ||
| double? contentDuration, |
Collaborator
There was a problem hiding this comment.
Same comments throughout this class.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support #110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
…r#173290) flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…r#173290) flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…r#173290) flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…r#173290) flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3