[video_player] Use CADisplayLink on macOS 14.0+ #9533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks the CVDisplayLink-based implementation that was previously used on macOS in all cases with deprecation suppressions, and switches macOS 14+ to share the CADisplayLink-based implementation that is currently used for iOS. Fixes flutter/flutter#171391
stuartmorgan-g
requested review from
LongCatIsLooong and
hellohuanlin
as code owners
jmagman
approved these changes
Jun 30, 2025
| @end | ||
|
|
||
| // An implementation of FVPDisplayLink using CADisplayLink. | ||
| @interface FVPCADisplayLink : NSObject <FVPDisplayLink> |
Member
There was a problem hiding this comment.
Nit: It's hard to see the difference between FVPCADisplayLink and FVPCVDisplayLink. Could we name it FVPCoreAnimationDisplayLink? That seems outrageously long. If not, what you have is fine.
Collaborator
Author
There was a problem hiding this comment.
I renamed FVPCVDisplayLink to FVPCoreVideoDisplayLink so that they are visually distinct, but it's the legacy one that's really long.
jmagman
reviewed
Jun 30, 2025
| @interface FVPDisplayLink () | ||
| @interface FVPCADisplayLink () | ||
| // The underlying display link implementation. | ||
| @property(nonatomic) CADisplayLink *displayLink; |
Member
There was a problem hiding this comment.
- NOTE | [OSX] xcodebuild: /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPCADisplayLink.m:19:1: note: annotate 'onDisplayLink:' with an availability attribute to silence this warning
- WARN | [OSX] xcodebuild: /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPCADisplayLink.m:31:24: warning: 'CADisplayLink' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
- NOTE | [OSX] xcodebuild: /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPCADisplayLink.m:31:1: note: annotate 'onDisplayLink:' with an availability attribute to silence this warning
- WARN | [OSX] xcodebuild: /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPCADisplayLink.m:40:22: warning: 'CADisplayLink' is only available on macOS 14.0 or newer [-Wunguarded-availability-new]
- NOTE | [OSX] xcodebuild: /Volumes/Work/s/w/ir/x/w/packages/packages/video_player/video_player_avfoundation/darwin/video_player_avfoundation/Sources/video_player_avfoundation/FVPCADisplayLink.m:38:12: note: annotate '' with an availability attribute to silence this warning
Collaborator
Author
There was a problem hiding this comment.
Oops, I meant to go back and figure out annotations once I had everything working.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 1, 2025
flutter/packages@471bfd3...3dc682d 2025-07-01 [email protected] [video_player] Use CADisplayLink on macOS 14.0+ (flutter/packages#9533) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump exoplayer_version from 1.4.1 to 1.5.1 in /packages/video_player/video_player_android/android (flutter/packages#8414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
…r#171458) flutter/packages@471bfd3...3dc682d 2025-07-01 [email protected] [video_player] Use CADisplayLink on macOS 14.0+ (flutter/packages#9533) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump exoplayer_version from 1.4.1 to 1.5.1 in /packages/video_player/video_player_android/android (flutter/packages#8414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Marks the CVDisplayLink-based implementation that was previously used on macOS in all cases with deprecation suppressions, and switches macOS 14+ to share the CADisplayLink-based implementation that is currently used for iOS. Fixes flutter/flutter#171391 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…r#171458) flutter/packages@471bfd3...3dc682d 2025-07-01 [email protected] [video_player] Use CADisplayLink on macOS 14.0+ (flutter/packages#9533) 2025-06-30 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump exoplayer_version from 1.4.1 to 1.5.1 in /packages/video_player/video_player_android/android (flutter/packages#8414) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks the CVDisplayLink-based implementation that was previously used on macOS in all cases with deprecation suppressions, and switches macOS 14+ to share the CADisplayLink-based implementation that is currently used for iOS.
Fixes flutter/flutter#171391
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3