Skip to content

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 13, 2025

StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@jmagman jmagman marked this pull request as ready for review June 26, 2025 16:25
@jmagman jmagman requested a review from LouiseHsu June 26, 2025 16:25
Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, i dont even remember writing that todo 😞
lgtm!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2025
@auto-submit auto-submit bot merged commit d76cf68 into flutter:main Jun 26, 2025
78 checks passed
@jmagman
Copy link
Member Author

jmagman commented Jun 26, 2025

oof, i dont even remember writing that todo 😞 lgtm!

I wrote that one 🙂
https://github.com/flutter/packages/pull/7431/files#r1733599092

@jmagman jmagman deleted the in-app-purchase-deprecation-remove branch June 26, 2025 17:16
@jmagman jmagman added the revert Label used to revert changes in a closed and merged pull request. label Jun 26, 2025
Copy link
Contributor

auto-submit bot commented Jun 26, 2025

A reason for requesting a revert of flutter/packages/9429 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jun 26, 2025
@jmagman
Copy link
Member Author

jmagman commented Jun 26, 2025

Reason for revert: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout

@jmagman jmagman added the revert Label used to revert changes in a closed and merged pull request. label Jun 26, 2025
auto-submit bot pushed a commit that referenced this pull request Jun 26, 2025
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jun 26, 2025
auto-submit bot added a commit that referenced this pull request Jun 26, 2025
…lusion list (#9429)" (#9507)

Reverts: #9429
Initiated by: jmagman
Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout
Original PR Author: jmagman

Reviewed By: {LouiseHsu}

This change reverts the following previous change:
StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 27, 2025
flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
…r#171292)

flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (flutter#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(flutter#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…st (flutter#9429)

StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…lusion list (flutter#9429)" (flutter#9507)

Reverts: flutter#9429
Initiated by: jmagman
Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout
Original PR Author: jmagman

Reviewed By: {LouiseHsu}

This change reverts the following previous change:
StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants