-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[webview_flutter] Adds support to control whether to draw scrollbars #9024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
49f57ba
feat: Add scrollBarEnabled function
1f1ad6f
chore: Modify pubspec for test setup
4217429
test: Add dart test code
45abbc1
reset wkwebview
bparrishMines afd7fc1
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines d214e1a
undo pubspec changes
bparrishMines 13421ca
proper dependency overrides
bparrishMines 05ab710
update platform interface
bparrishMines c8387fe
dart side of impl
bparrishMines 8475a1e
java side impl
bparrishMines 7499acd
ios impl
bparrishMines 45f7a89
app facing updated
bparrishMines 5778e9f
formatting
bparrishMines 61de0eb
suppress
bparrishMines 72f9fea
add destroy
bparrishMines e6d0a5f
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines ac414de
update generated code
bparrishMines 1bdd7c6
regen mocks
bparrishMines 0f1461e
add destory method
bparrishMines a6b6286
formatting
bparrishMines 274f10b
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines b35c5fb
format and add support query
bparrishMines d9de673
query test platform interface
bparrishMines cd1b2d7
reeturn value based on platform for wkwebview
bparrishMines 1d52c56
accidental character
bparrishMines 01fb364
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines 61ab32a
docs that i prefer
bparrishMines a35c481
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines a523cae
formatting
bparrishMines cb123a5
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines b667829
fix pubspecs and changelog
bparrishMines 518111c
fix pubspecs
bparrishMines c88c097
actual fix
bparrishMines 0ecd78f
and one more file
bparrishMines 2be1755
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines 181138b
change to future bool
bparrishMines 43ba081
Merge branch 'main' of github.com:flutter/packages into webview_scrol…
bparrishMines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also plumb through a
Future<bool> supportsSetScrollBarsEnabled()
method to the platform interface layer that clients can use to detect whether this is safe to call per https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#api-support-queries ? This won't make sense on all platforms, so we should expect that clients will need a support query indefinitely.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also assuming you meant for this to return
bool
and notFuture<bool>
too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed this, and didn't catch it in the platform interface review. It should have been
Future<bool>
in case there were a platform that could only determine this at runtime (e.g., based on the OS version).Not a big deal though as that's an unlikely case to ever hit.