Skip to content

[all_packages] Enforce property assignment for compile sdk over method assignment #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2025
Merged

[all_packages] Enforce property assignment for compile sdk over method assignment #8897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a771c27
Enforce property assignment for compile sdk over method assignment
reidbaker Mar 25, 2025
263d5f6
Formatting and quotes around compile sdk equals
reidbaker Mar 25, 2025
b894db1
Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
reidbaker Mar 25, 2025
44edef5
fix all instances of compileSdk using method set
reidbaker Mar 25, 2025
5ebeea8
dont change lifecyle minsdkVersion
reidbaker Mar 25, 2025
e076a1a
leave legacy project alone.
reidbaker Mar 25, 2025
ddd8198
Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
reidbaker Mar 25, 2025
87a1d52
Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
ditman Mar 27, 2025
998eb40
Merge branch 'main' into r-2025-03-25-property-assignment-compilesdk
reidbaker Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/camera/camera/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.cameraexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.cameraexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
4 changes: 2 additions & 2 deletions packages/camera/camera_android_camerax/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.cameraxexample'
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/espresso/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
namespace "com.example.espresso_example"

Expand Down
2 changes: 1 addition & 1 deletion packages/extension_google_sign_in_as_googleapis_auth/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/file_selector/file_selector/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace "dev.flutter.plugins.file_selector_example"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/file_selector/file_selector_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace "dev.flutter.packages.file_selector_android_example"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_adaptive_scaffold/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_image/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace "com.example.example"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_plugin_android_lifecycle/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {


android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.googlemapsexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.googlesigninexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.googlesigninexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.imagepickerexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion
testOptions.unitTests.includeAndroidResources = true


Expand Down
2 changes: 1 addition & 1 deletion packages/image_picker/image_picker_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.imagepickerexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion
testOptions.unitTests.includeAndroidResources = true


Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ android {
}
}

compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ if (!configured) {

android {
namespace 'io.flutter.plugins.inapppurchaseexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

signingConfigs {
release {
Expand Down
4 changes: 2 additions & 2 deletions packages/interactive_media_ads/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace "dev.flutter.packages.interactive_media_ads_example"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/local_auth/local_auth/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.localauthexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/local_auth/local_auth_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.localauthexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/palette_generator/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ if (flutterVersionName == null) {
}

android {
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.pathproviderexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/path_provider/path_provider_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.pathproviderexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
4 changes: 2 additions & 2 deletions packages/pigeon/example/app/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace "dev.flutter.pigeon_example_app"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions ...ges/pigeon/platform_tests/alternate_language_test_plugin/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace 'com.example.alternate_language_test_plugin_example'
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/pigeon/platform_tests/test_plugin/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace 'com.example.test_plugin_example'
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/quick_actions/quick_actions/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.quickactionsexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/quick_actions/quick_actions_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def androidXTestVersion = '1.4.0'

android {
namespace 'io.flutter.plugins.quickactionsexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/example/hello/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'dev.flutter.rfw.examples.hello'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/example/local/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'dev.flutter.rfw.examples.local'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/rfw/example/remote/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'dev.flutter.rfw.examples.remote'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/shared_preferences/shared_preferences/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.sharedpreferencesexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
Expand Down
4 changes: 2 additions & 2 deletions packages/shared_preferences/shared_preferences_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ if (flutterVersionName == null) {

android {
namespace "dev.flutter.plugins.shared_preferences_example"
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
4 changes: 2 additions & 2 deletions packages/two_dimensional_scrollables/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ if (flutterVersionName == null) {

android {
namespace 'dev.flutter.packages.two_dimensional_scrollables.example'
compileSdk flutter.compileSdkVersion
ndkVersion flutter.ndkVersion
compileSdk = flutter.compileSdkVersion
ndkVersion = flutter.ndkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.urllauncherexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.urllauncherexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.videoplayerexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player_android/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.videoplayerexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion

compileOptions {
sourceCompatibility JavaVersion.VERSION_11
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/webview_flutter/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if (flutterVersionName == null) {

android {
namespace 'io.flutter.plugins.webviewflutterexample'
compileSdk flutter.compileSdkVersion
compileSdk = flutter.compileSdkVersion


defaultConfig {
Expand Down
Loading