Skip to content

Conversation

Ape
Copy link
Contributor

@Ape Ape commented Mar 7, 2025

The previous version had a typo where it specified the mime types using the extensions field.

part of flutter/flutter#148635

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under.
  • All existing and new tests are passing.

@Ape
Copy link
Contributor Author

Ape commented Mar 7, 2025

I don't really know why the tree-status check is failing.

@Ape Ape force-pushed the fix_image_picker_linux branch from f6e0eda to f7499a6 Compare March 7, 2025 11:41
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM other than the version needing a minor adjustment.

part of flutter/flutter#148635

How is this related to that issue? The code in that issue report uses pickImage, not pickMedia, and is distro-specific.

This bug would only affect pickMedia and pickMultipleMedia, and would affect all distros.

@Ape Ape force-pushed the fix_image_picker_linux branch from f7499a6 to 7325703 Compare March 7, 2025 19:51
@Ape
Copy link
Contributor Author

Ape commented Mar 7, 2025

How is this related to that issue?

Oh, you are right. That was the issue I first found while searching about my issues, but turns out it's not the same issue.

Should I create a new issue for this or can we merge the PR like this?

@Ape Ape force-pushed the fix_image_picker_linux branch from 7325703 to 2ebb5c9 Compare March 7, 2025 19:56
@stuartmorgan-g
Copy link
Collaborator

For something this straightforward it's fine to skip filing the issue.

The previous version had a typo where it specified the mime types using
the `extensions` field.
@Ape Ape force-pushed the fix_image_picker_linux branch from 2ebb5c9 to af96011 Compare March 7, 2025 20:01
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2025
@auto-submit auto-submit bot merged commit d450e1b into flutter:main Mar 17, 2025
82 checks passed
@Ape Ape deleted the fix_image_picker_linux branch March 18, 2025 06:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 18, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 18, 2025
flutter/packages@ff7724c...d450e1b

2025-03-17 [email protected] [image_picker] Fix getMedia on Linux
(flutter/packages#8811)
2025-03-17 [email protected] Add a carve-out on the commenting
requirement (flutter/packages#8855)
2025-03-17 [email protected] [camera] Fix unit test asserting
external value (flutter/packages#8814)
2025-03-17 [email protected] [pigeon] adds Internal options
(flutter/packages#8709)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
The previous version had a typo where it specified the mime types using the `extensions` field.

~~part of flutter/flutter#148635

## Pre-Review Checklist
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
The previous version had a typo where it specified the mime types using the `extensions` field.

~~part of flutter/flutter#148635

## Pre-Review Checklist
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
…r#165398)

flutter/packages@ff7724c...d450e1b

2025-03-17 [email protected] [image_picker] Fix getMedia on Linux
(flutter/packages#8811)
2025-03-17 [email protected] Add a carve-out on the commenting
requirement (flutter/packages#8855)
2025-03-17 [email protected] [camera] Fix unit test asserting
external value (flutter/packages#8814)
2025-03-17 [email protected] [pigeon] adds Internal options
(flutter/packages#8709)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants