-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[image_picker] Fix getMedia on Linux #8811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
66f1d4e
to
f6e0eda
Compare
I don't really know why the |
f6e0eda
to
f7499a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! LGTM other than the version needing a minor adjustment.
part of flutter/flutter#148635
How is this related to that issue? The code in that issue report uses pickImage
, not pickMedia
, and is distro-specific.
This bug would only affect pickMedia
and pickMultipleMedia
, and would affect all distros.
f7499a6
to
7325703
Compare
Oh, you are right. That was the issue I first found while searching about my issues, but turns out it's not the same issue. Should I create a new issue for this or can we merge the PR like this? |
7325703
to
2ebb5c9
Compare
For something this straightforward it's fine to skip filing the issue. |
The previous version had a typo where it specified the mime types using the `extensions` field.
2ebb5c9
to
af96011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for correcting this.
flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The previous version had a typo where it specified the mime types using the `extensions` field. ~~part of flutter/flutter#148635 ## Pre-Review Checklist
The previous version had a typo where it specified the mime types using the `extensions` field. ~~part of flutter/flutter#148635 ## Pre-Review Checklist
…r#165398) flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The previous version had a typo where it specified the mime types using the
extensions
field.part of flutter/flutter#148635Pre-Review Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.CHANGELOG.md
to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.///
).