[image_picker] Fix getMedia on Linux #8811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ape
force-pushed
the
fix_image_picker_linux
branch
from
66f1d4e to
f6e0eda
Compare
|
I don't really know why the |
Ape
force-pushed
the
fix_image_picker_linux
branch
from
f6e0eda to
f7499a6
Compare
stuartmorgan-g
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Thanks for the contribution! LGTM other than the version needing a minor adjustment.
part of flutter/flutter#148635
How is this related to that issue? The code in that issue report uses pickImage, not pickMedia, and is distro-specific.
This bug would only affect pickMedia and pickMultipleMedia, and would affect all distros.
Ape
force-pushed
the
fix_image_picker_linux
branch
from
f7499a6 to
7325703
Compare
Oh, you are right. That was the issue I first found while searching about my issues, but turns out it's not the same issue. Should I create a new issue for this or can we merge the PR like this? |
Ape
force-pushed
the
fix_image_picker_linux
branch
from
7325703 to
2ebb5c9
Compare
|
For something this straightforward it's fine to skip filing the issue. |
The previous version had a typo where it specified the mime types using the `extensions` field.
Ape
force-pushed
the
fix_image_picker_linux
branch
from
2ebb5c9 to
af96011
Compare
tarrinneal
approved these changes
Mar 17, 2025
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2025
flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
The previous version had a typo where it specified the mime types using the `extensions` field. ~~part of flutter/flutter#148635 ## Pre-Review Checklist
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
The previous version had a typo where it specified the mime types using the `extensions` field. ~~part of flutter/flutter#148635 ## Pre-Review Checklist
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…r#165398) flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version had a typo where it specified the mime types using the
extensionsfield.part of flutter/flutter#148635Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under.CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under.///).