Skip to content

Conversation

neilself
Copy link
Contributor

@neilself neilself commented Feb 28, 2025

This PR contains the platform interface changes for the main PR 8573. As a whole, these changes add a new option to explicitly specify the account name on Android while signing in within the google_sign_in package.

Flutter issue: 163257

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@neilself neilself changed the title [google_sign_in_platform_interface] Add Android account name field as optional [google_sign_in] Add Android account name field as optional (platform interface changes) Feb 28, 2025
@neilself neilself marked this pull request as ready for review February 28, 2025 02:18
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 for second approval

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2025
@auto-submit auto-submit bot merged commit 1faaa04 into flutter:main Mar 3, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2025
flutter/packages@9e4684e...abba683

2025-03-05 [email protected] [camera_avfoundation] Tests
backfilling - part 1 (flutter/packages#8698)
2025-03-04 [email protected]
[go_router_builder]: Fix `The argument type 'String?' can't be assigned
to the parameter type 'String' because 'String?' ` on path and query
params (flutter/packages#8737)
2025-03-04 [email protected] [video_player_android] Platform
view support (flutter/packages#8466)
2025-03-04 [email protected]
[webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request`
(flutter/packages#8766)
2025-03-03 [email protected] Manual roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8775)
2025-03-03 [email protected] Roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8774)
2025-03-03 [email protected] [flutter_plugin_android_lifecycle] Uses
flutter.compileSdkVersion, bumps minimum flutter version to 3.27
(flutter/packages#8760)
2025-03-03 [email protected] [google_sign_in] Add Android account name
field as optional (platform interface changes) (flutter/packages#8735)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
… interface changes) (flutter#8735)

This PR contains the platform interface changes for the main PR [8573](flutter#8573). As a whole, these changes add a new option to explicitly specify the account name on Android while signing in within the google_sign_in package.

Flutter issue: [163257](flutter/flutter#163257)
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
… interface changes) (flutter#8735)

This PR contains the platform interface changes for the main PR [8573](flutter#8573). As a whole, these changes add a new option to explicitly specify the account name on Android while signing in within the google_sign_in package.

Flutter issue: [163257](flutter/flutter#163257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: google_sign_in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants