[google_maps_flutter] Add ability to animate camera with duration - platform impls #8659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
reviewed
Feb 21, 2025
Contributor
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
I looked for a test for getCameraPosition which I believe was added in this pr. If there is a test can you point it out to me, if there is not can you add one?
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
Outdated
Show resolved
Hide resolved
jokerttu
force-pushed
the
feature/animate-camera-duration-platform-impls
branch
from
24d7e9f to
aee7fd1
Compare
Contributor
Author
@reidbaker this is addressed on latest commit: |
jokerttu
force-pushed
the
feature/animate-camera-duration-platform-impls
branch
from
aee7fd1 to
58f08cc
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration-platform-impls
branch
from
58f08cc to
ff6ad17
Compare
Contributor
Author
|
Rebased and fixed conflicts causes by the 297d5a1 |
reidbaker
approved these changes
Mar 20, 2025
Contributor
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
android code looks good.
stuartmorgan-g
requested changes
Mar 20, 2025
| /// The suffix this instance was registered under with Pigeon. | ||
| @property(nonatomic, copy) NSString *pigeonSuffix; | ||
| /// The transaction wrapper to use for camera animations. | ||
| @property(nonatomic, strong) id<FGMCATransactionProtocol> transactionWrapper; |
Collaborator
There was a problem hiding this comment.
Unless I'm missing something this is identical to the declaration in the test header, in which case it shouldn't be repeated here.
Collaborator
There was a problem hiding this comment.
(This file should import #import "GoogleMapController_Test.h" just after #import "GoogleMapController.h", which it looks like is currently missing.)
| return _hostApi(mapId) | ||
| .animateCamera(_platformCameraUpdateFromCameraUpdate(cameraUpdate)); | ||
| return _hostApi(mapId).animateCamera( | ||
| _platformCameraUpdateFromCameraUpdate(cameraUpdate), null); |
Collaborator
There was a problem hiding this comment.
Prefer calling the replacement method (with a null duration in this case) to duplicating the implementation. Otherwise it's easy for someone to change the new method later and forget to keep the old method in sync.
Contributor
Author
There was a problem hiding this comment.
Replaced with:
return animateCameraWithConfiguration(
cameraUpdate, const CameraUpdateAnimationConfiguration(),
mapId: mapId);| return _hostApi(mapId) | ||
| .animateCamera(_platformCameraUpdateFromCameraUpdate(cameraUpdate)); | ||
| return _hostApi(mapId).animateCamera( | ||
| _platformCameraUpdateFromCameraUpdate(cameraUpdate), null); |
Collaborator
There was a problem hiding this comment.
See comment in iOS about calling the new method.
Contributor
Author
There was a problem hiding this comment.
Replaced with:
return animateCameraWithConfiguration(
cameraUpdate, const CameraUpdateAnimationConfiguration(),
mapId: mapId);| /// FLTGoogleMapController instance is what needs to trigger Pigeon unregistration, so can't be | ||
| /// the target of the registration. | ||
| @interface FGMMapInspector : NSObject <FGMMapsInspectorApi> | ||
| @end |
Collaborator
There was a problem hiding this comment.
Can these go in the test header instead? I would not expect this to need to be public for non-test purposes.
stuartmorgan-g
approved these changes
Mar 21, 2025
| @import XCTest; | ||
| @import GoogleMaps; | ||
|
|
||
| #import <GoogleMapController_Test.h> |
Collaborator
There was a problem hiding this comment.
Is this needed? I would expect the @import on line 6 to handle this.
jokerttu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2025
…ration - platform impls (flutter/packages#8659)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2025
flutter/packages@6981639...c27d2fe 2025-03-24 [email protected] [google_maps_flutter] Add ability to animate camera with duration - platform impls (flutter/packages#8659) 2025-03-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.0 in /packages/interactive_media_ads/android (flutter/packages#8832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…latform impls (flutter#8659) This PR contains platform implementations for the ability to animate camera with duration (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…r#165806) flutter/packages@6981639...c27d2fe 2025-03-24 [email protected] [google_maps_flutter] Add ability to animate camera with duration - platform impls (flutter/packages#8659) 2025-03-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.0 in /packages/interactive_media_ads/android (flutter/packages#8832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…latform impls (flutter#8659) This PR contains platform implementations for the ability to animate camera with duration (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…r#165806) flutter/packages@6981639...c27d2fe 2025-03-24 [email protected] [google_maps_flutter] Add ability to animate camera with duration - platform impls (flutter/packages#8659) 2025-03-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.0.0 to 8.9.0 in /packages/interactive_media_ads/android (flutter/packages#8832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains platform implementations for the ability to animate camera with duration (#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.