-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[google_maps_flutter] Platform interface for camera animation duration #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter] Platform interface for camera animation duration #8596
Conversation
7aa3736 to
ce3c933
Compare
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few last minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to animate" -> "for animating"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"an animation"
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/camera.dart
Outdated
Show resolved
Hide resolved
ce3c933 to
a88b79a
Compare
|
Feel free to |
flutter/packages@cb4fb13...a9b9172 2025-02-19 [email protected] [google_maps_flutter] Platform interface for camera animation duration (flutter/packages#8596) 2025-02-18 [email protected] [various] Update Pigeon for task queue changes (flutter/packages#8654) 2025-02-18 [email protected] [pigeon] Fixes potential race condition caused by a ProxyApi constructor message call being made in an async method (flutter/packages#8656) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter#8596) This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
flutter#8596) This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
This PR contains platform interface changes for support to adjust camera animation speed (#7648).
Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.