Skip to content

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Feb 10, 2025

This PR contains platform interface changes for support to adjust camera animation speed (#7648).

Linked issue: flutter/flutter#39810
Linked issue: flutter/flutter#44284

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jokerttu jokerttu changed the title [google_maps_flutter] Platform interface for camera animation configuration [google_maps_flutter] Platform interface for camera animation duration Feb 10, 2025
@jokerttu jokerttu marked this pull request as ready for review February 11, 2025 09:30
@jokerttu jokerttu force-pushed the feature/animate-camera-duration-platform-interface branch 2 times, most recently from 7aa3736 to ce3c933 Compare February 14, 2025 12:51
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few last minor comments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to animate" -> "for animating"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an animation"

@jokerttu jokerttu force-pushed the feature/animate-camera-duration-platform-interface branch from ce3c933 to a88b79a Compare February 17, 2025 11:01
@stuartmorgan-g
Copy link
Collaborator

Feel free to autosubmit this whenever you are ready.

@jokerttu jokerttu added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 19, 2025
@auto-submit auto-submit bot merged commit a9b9172 into flutter:main Feb 19, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 19, 2025
flutter/packages@cb4fb13...a9b9172

2025-02-19 [email protected] [google_maps_flutter] Platform
interface for camera animation duration (flutter/packages#8596)
2025-02-18 [email protected] [various] Update Pigeon for task
queue changes (flutter/packages#8654)
2025-02-18 [email protected] [pigeon]
Fixes potential race condition caused by a ProxyApi constructor message
call being made in an async method (flutter/packages#8656)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
flutter#8596)

This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).

Linked issue:  flutter/flutter#39810
Linked issue:  flutter/flutter#44284
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
flutter#8596)

This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648).

Linked issue:  flutter/flutter#39810
Linked issue:  flutter/flutter#44284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: google_maps_flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants