Skip to content

[video_player_avfoundation] macOS platform view support #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 159 commits into from
Closed

[video_player_avfoundation] macOS platform view support #8558

wants to merge 159 commits into from

Conversation

FirentisTFW
Copy link
Contributor

[DRAFT]
This PR contains changes from #8237. Once that PR is merged (and video_player package is published with platform view support on iOS and Android), this PR will be rebased and adjusted. For now it will hang as a draft.

This PR will add platform view support to video_player package for macOS.

Pre-launch Checklist

@FirentisTFW
Extract FVPFrameUpdater and FVPVideoPlayer from plugin file to separa…
82d5333 
…te files
@FirentisTFW
Add docs for FVPFrameUpdater and FVPVideoPlayer interfaces
a2d3d9f
@FirentisTFW
Remove unused imports and #pragma statements
a74c720
@FirentisTFW
Add empty lines at the end of files
9092b71
@FirentisTFW
Bump version to 2.6.4 and update changelog
add5719
@FirentisTFW
Move GLKit import from header file to source file
9587ad0
@FirentisTFW
Add FVPVideoPlayerPlugin_Test import to plugin file
83cec0c
@FirentisTFW
Fix parameter type in interface constructor
99123db
@FirentisTFW
Separate plugin and factory classes by pragma mark
9545fda
@FirentisTFW
Add nullability type specifiers to FVPVideoPlayer interface
75b5ab9
@FirentisTFW
Make properties not needed in header of FVPVideoPlayer private
5ec766f
@FirentisTFW
Use nonnull macro for the whole header file
c958a4a
@FirentisTFW
Make updatePlayingState private for FVPVideoPlayer
0a707a5
@FirentisTFW
Make texture registry private for FVPFrameUpdater
0055ea3
@FirentisTFW
Move code from Plugin_Test file to different files
717315e
@FirentisTFW
Make changelog description more general
489f2a9
@FirentisTFW
Add a doc comment for FVPDefaultAVFactory
599adc8
@FirentisTFW
Make lastKnownAvailableTime property of FVPFrameUpdater readonly
513961c
@FirentisTFW
Add _Test.h file for FVPVideoPlayer
ff11b63
@FirentisTFW
Add FVPNativeVideoViewFactory and FVPNativeVideoView (everything in o…
12efd58 
…ne file for now)
@FirentisTFW
Use platform view in Dart Code (hardcoded)
42c3724
@FirentisTFW
Add PlatformVideoViewType enum to allow choosing between texture view…
968bbf1 
… and platform view for each video
@FirentisTFW
Pass video view type to controller in iOS example project
dc85756
@FirentisTFW
Add two FVPVideoPlayer implementations - basic and texture-approach o…
c9f27c5 
…riented
@FirentisTFW
Split iOS native classes into multiple files
b3151e2
@FirentisTFW
Only register native view factory for iOS, not MacOS
db1a943
@FirentisTFW
Use only textue view on MacOS in example app
0e3b346
@FirentisTFW
Refactor imports
6d317a5
@FirentisTFW
Allow choosing between texture view and platform view in example app
9bace40
@FirentisTFW
Remove redundant import
3bf34f9
@FirentisTFW
Fix return type
80fffcf
@FirentisTFW
Merge branch 'main' into feature/video-player-platform-view-support
5a85403
@FirentisTFW
Bump platform interface dependency to 6.3.0
6d236b4
@FirentisTFW
Rename textureId to playerId in platform interace methods
7cd5f14
@FirentisTFW
Rename textureId to playerId in iOS Dart files
3d3b59d
@FirentisTFW
Move dispose guard to texture-based video player, simplify unregister…
ebe123a 
…ing texture logic
@FirentisTFW
Rename textureId to playerId in iOS native code
d486095
@FirentisTFW
Bump platform interface dependency to 6.3.0 in example app
cdd1458
@FirentisTFW
Remove outdated information from doc comment
f920a38
@FirentisTFW
Rename FromOptions to WithOptions
84a0538
@FirentisTFW
Use weak self to avoid retain cycles
d1841b3
@FirentisTFW
Rename create-player methods
29cddaf
@FirentisTFW
Comment on using FVPVideoPlayer
db469b3
@FirentisTFW
Fall back to texture view if platform view is requested on MacOS
417e771
@FirentisTFW
Describe missing support for MacOS platform views in readme
c1497d7
@FirentisTFW
Remove flutterViewLayer from FVPVideoPlayer interface
b7dc9ff
@FirentisTFW
Add more details to comments in FVPTextureBasedVideoPlayer and FVPVid…
ecfd81f 
…eoPlayer
@FirentisTFW
Add macOS platform view support
f54f9c8
@cbenhagen
Copy link
Contributor

@FirentisTFW now that #8237 has been merged, what's missing to add macOS support?

@FirentisTFW
Copy link
Contributor Author

@cbenhagen We wanted to fully release iOS and Android implementations first to have less potential pain points.

However, these were also not fully released yet. #8810 is adding the support to the app-facing package. I still haven't published it though, since it seems that there are some issues when rendering Android's SurfaceView (which is used by video_player_android) in Flutter. There's an issue for that: #164899. I was going to wait a little bit more for the Android team's input there before I try to work around it again. Only then I wanted to publish the app-facing PR and then follow up with the macOS support.

@Piinks
Copy link
Contributor

Piinks commented Jun 4, 2025

Hey @FirentisTFW! Is this change still on your radar?

@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 7, 2025
Merged
11 tasks
@stuartmorgan-g
Copy link
Collaborator

Closing in favor of #9576

auto-submit bot pushed a commit that referenced this pull request Jul 8, 2025
@stuartmorgan-g
[video_player] Adds platform view support on macOS (#9576)
4a231ae 
Adds macOS support for the platform view display option, brining macOS in line with the iOS implementation.

This:
- extracts the macOS additions from #8558 as cherry picks,
- updates it for some changes that happened during iOS review, and 
- makes some minor adjustments (mostly combining the factory classes into one shared file)

Part of flutter/flutter#86613

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
@stuartmorgan-g @vashworth
[video_player] Adds platform view support on macOS (flutter#9576)
f5f6ee4 
Adds macOS support for the platform view display option, brining macOS in line with the iOS implementation.

This:
- extracts the macOS additions from flutter#8558 as cherry picks,
- updates it for some changes that happened during iOS review, and 
- makes some minor adjustments (mostly combining the factory classes into one shared file)

Part of flutter/flutter#86613

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong LongCatIsLooong will be requested when the pull request is marked ready for review LongCatIsLooong is a code owner

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin will be requested when the pull request is marked ready for review hellohuanlin is a code owner

Assignees
No one assigned
Labels
p: video_player platform-ios platform-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FirentisTFW @cbenhagen @Piinks @stuartmorgan-g