[camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests #8363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
reviewed
Jan 3, 2025
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCaptureDeviceControlling.m
Show resolved
Hide resolved
hellohuanlin
reviewed
Jan 8, 2025
hellohuanlin
reviewed
Jan 8, 2025
...dation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDeviceControlling.h
Outdated
Show resolved
Hide resolved
stuartmorgan-g
requested changes
Jan 29, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTest.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCameraDeviceDiscoverer.h
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureDevice.h
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureSession.h
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockEventChannel.h
Show resolved
Hide resolved
...era_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/CameraPlugin_Test.h
Outdated
Show resolved
Hide resolved
...era_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/CameraPlugin_Test.h
Outdated
Show resolved
Hide resolved
...vfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCameraDeviceDiscovering.m
Outdated
Show resolved
Hide resolved
...vfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCameraDeviceDiscovering.m
Outdated
Show resolved
Hide resolved
...amera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPlugin.m
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Feb 3, 2025
...ra/camera_avfoundation/example/ios/RunnerTests/CameraCaptureSessionQueueRaceConditionTests.m
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureDevice.m
Show resolved
Hide resolved
...mera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDevice.h
Show resolved
Hide resolved
...mera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDevice.h
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Feb 6, 2025
...vfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCameraDeviceDiscovering.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockCaptureDevice.m
Show resolved
Hide resolved
|
I fixed all the nits. |
|
Changes LGTM; feel free to |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2025
…ientationTests and ThreadSafeEventChannelTests (flutter/packages#8363)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2025
flutter/packages@e6ce02c...625023a 2025-02-07 [email protected] [camera] Remove OCMock from AvailableCamerasTests, CameraOrientationTests and ThreadSafeEventChannelTests (flutter/packages#8363) 2025-02-06 [email protected] [pigeon] Adds annotation options to omit shared classes used in Event Channels (flutter/packages#8566) 2025-02-06 [email protected] [quick_actions] Update Android Pigeon version (flutter/packages#8580) 2025-02-05 [email protected] [ci] Move Wasm test shards out of bringup. (flutter/packages#8572) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…ests and ThreadSafeEventChannelTests (flutter#8363) Follow-up on flutter#8342. This should be merged after flutter#8351 - Removes OCMock dependency in `AvailableCamerasTests.m`, `CameraOrientationTests.m` and `ThreadSafeEventChannelTests.m` - Introduces new protocol wrappers to enable mocking `FLTEventChannel` and `FLTCameraDeviceDiscovering`
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…ests and ThreadSafeEventChannelTests (flutter#8363) Follow-up on flutter#8342. This should be merged after flutter#8351 - Removes OCMock dependency in `AvailableCamerasTests.m`, `CameraOrientationTests.m` and `ThreadSafeEventChannelTests.m` - Introduces new protocol wrappers to enable mocking `FLTEventChannel` and `FLTCameraDeviceDiscovering`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #8342. This should be merged after #8351
AvailableCamerasTests.m,CameraOrientationTests.mandThreadSafeEventChannelTests.mFLTEventChannelandFLTCameraDeviceDiscoveringPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.