Skip to content

Conversation

matanlurey
Copy link
Contributor

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just want to confirm that we don't need to care about calling stop? I see this note about needing to include it in a particular case so just double checking!

@matanlurey
Copy link
Contributor Author

I see this note about needing to include it in a particular case so just double checking!

Good callout! I think it's more of a "can stop be called" versus stop must be called, but thanks for checking!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2024
@auto-submit auto-submit bot merged commit f1a3da2 into main Oct 9, 2024
76 checks passed
@auto-submit auto-submit bot deleted the video_player-android-moreBackgrounding branch October 9, 2024 22:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 10, 2024
flutter/packages@9d00fb1...f1a3da2

2024-10-09 [email protected] Remove additional (harmless but annoying) native stack traces. (flutter/packages#7837)
2024-10-09 [email protected] Roll Flutter from 0917e9d to 2d45fb3 (50 revisions) (flutter/packages#7836)
2024-10-09 [email protected] [camera_android] Begin conversion to Pigeon (flutter/packages#7755)
2024-10-09 [email protected] [google_maps_flutter_android] Add `PlatformCap` pigeon type. (flutter/packages#7639)
2024-10-09 [email protected] [camerax] Revert "Explicitly remove READ_EXTERNAL_STORAGE permission" (flutter/packages#7826)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: video_player platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[video_player] Native Stack trace crashes when putting the app in inactive state while video is playing on Android
2 participants