Skip to content

Conversation

@Craftplacer
Copy link
Contributor

This pull request adds a property called stateHome that provides the directory for XDG_STATE_HOME.

Fixes flutter/flutter#155494

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the version increment, thanks for the contribution!

@stuartmorgan-g
Copy link
Collaborator

@robert-ancell Could you do the secondary approval on this one?

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2024
@auto-submit auto-submit bot merged commit b339722 into flutter:main Oct 4, 2024
75 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 4, 2024
flutter/packages@429650f...05bf1d4

2024-10-04 [email protected] [various] Update Swift plugins for non-nullable generics (flutter/packages#7742)
2024-10-04 [email protected] [url_launcher] Update Android Pigeon (flutter/packages#7744)
2024-10-04 [email protected] [xdg_directories] Add `stateHome` property (flutter/packages#7766)
2024-10-03 [email protected] [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781)
2024-10-03 [email protected] [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: xdg_directories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement $XDG_STATE_HOME in xdg_directories

3 participants