-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[xdg_directories] Add stateHome property
#7766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the version increment, thanks for the contribution!
|
@robert-ancell Could you do the secondary approval on this one? |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
robert-ancell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I checked it against https://specifications.freedesktop.org/basedir-spec/latest/index.html
flutter/packages@429650f...05bf1d4 2024-10-04 [email protected] [various] Update Swift plugins for non-nullable generics (flutter/packages#7742) 2024-10-04 [email protected] [url_launcher] Update Android Pigeon (flutter/packages#7744) 2024-10-04 [email protected] [xdg_directories] Add `stateHome` property (flutter/packages#7766) 2024-10-03 [email protected] [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781) 2024-10-03 [email protected] [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This pull request adds a property called
stateHomethat provides the directory forXDG_STATE_HOME.Fixes flutter/flutter#155494