-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[interactive_media_ads] Adds internal wrapper for iOS native IMAFriendlyObstruction
#7696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /// | ||
| /// See https://developers.google.com/ad-manager/dynamic-ad-insertion/sdk/ios/reference/Enums/IMAFriendlyObstructionPurpose.html. | ||
| enum FriendlyObstructionPurpose { | ||
| mediaControls, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the IMA docs don't include any doc comments: https://developers.google.com/ad-manager/dynamic-ad-insertion/sdk/ios/reference/Enums/IMAFriendlyObstructionPurpose.html
IMAFriendlyObstruction
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…`IMAFriendlyObstruction` (flutter/packages#7696)
…`IMAFriendlyObstruction` (flutter/packages#7696)
flutter/packages@f38b780...0321757 2024-09-26 [email protected] Roll Flutter from 538e742 to fa402c8 (19 revisions) (flutter/packages#7713) 2024-09-26 [email protected] [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090) 2024-09-26 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696) 2024-09-26 [email protected] Add a `@SuppressWarnings` in advance (flutter/packages#7712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@f38b780...0321757 2024-09-26 [email protected] Roll Flutter from 538e742 to fa402c8 (19 revisions) (flutter/packages#7713) 2024-09-26 [email protected] [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090) 2024-09-26 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696) 2024-09-26 [email protected] Add a `@SuppressWarnings` in advance (flutter/packages#7712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.