Skip to content

[pigeon] Validates support for nested collections with generic types. #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 19, 2024
Merged

[pigeon] Validates support for nested collections with generic types. #7614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae27688
add non nullable types to collections
tarrinneal Sep 6, 2024
f05d7b5
wrapped tests
tarrinneal Sep 9, 2024
cf4c27c
fix class checks
tarrinneal Sep 10, 2024
742cfb6
vers
tarrinneal Sep 10, 2024
ceed8ac
fix lunix
tarrinneal Sep 10, 2024
e8b2f32
Merge branch 'main' of github.com:flutter/packages into custom-codecs…
tarrinneal Sep 18, 2024
7a5b3a9
finish tests
tarrinneal Sep 18, 2024
f20fd97
change changelog
tarrinneal Sep 18, 2024
93d4600
revert versioning
tarrinneal Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/pigeon/pigeons/core_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,16 @@ class AllTypes {
required this.enumList,
required this.objectList,
required this.listList,
required this.mapList,

// Maps
required this.map,
required this.stringMap,
required this.intMap,
required this.enumMap,
required this.objectMap,
required this.listMap,
required this.mapMap,
});

bool aBool;
Expand All @@ -84,6 +87,7 @@ class AllTypes {
List<AnEnum> enumList;
List<Object> objectList;
List<List<Object?>> listList;
List<Map<Object?, Object?>> mapList;

// Maps
// ignore: strict_raw_type, always_specify_types
Expand All @@ -92,6 +96,8 @@ class AllTypes {
Map<int, int> intMap;
Map<AnEnum, AnEnum> enumMap;
Map<Object, Object> objectMap;
Map<int, List<Object?>> listMap;
Map<int, Map<Object?, Object?>> mapMap;
}

/// A class containing all supported nullable types.
Expand Down Expand Up @@ -123,6 +129,7 @@ class AllNullableTypes {
this.enumList,
this.objectList,
this.listList,
this.mapList,
this.recursiveClassList,

// Maps
Expand All @@ -131,6 +138,8 @@ class AllNullableTypes {
this.intMap,
this.enumMap,
this.objectMap,
this.listMap,
this.mapMap,
this.recursiveClassMap,
);

Expand Down Expand Up @@ -158,6 +167,7 @@ class AllNullableTypes {
List<AnEnum?>? enumList;
List<Object?>? objectList;
List<List<Object?>?>? listList;
List<Map<Object?, Object?>?>? mapList;
List<AllNullableTypes?>? recursiveClassList;

// Maps
Expand All @@ -167,6 +177,8 @@ class AllNullableTypes {
Map<int?, int?>? intMap;
Map<AnEnum?, AnEnum?>? enumMap;
Map<Object?, Object?>? objectMap;
Map<int?, List<Object?>?>? listMap;
Map<int?, Map<Object?, Object?>?>? mapMap;
Map<int?, AllNullableTypes?>? recursiveClassMap;
}

Expand Down Expand Up @@ -199,13 +211,16 @@ class AllNullableTypesWithoutRecursion {
this.enumList,
this.objectList,
this.listList,
this.mapList,

// Maps
this.map,
this.stringMap,
this.intMap,
this.enumMap,
this.objectMap,
this.listMap,
this.mapMap,
);

bool? aNullableBool;
Expand All @@ -231,6 +246,7 @@ class AllNullableTypesWithoutRecursion {
List<AnEnum?>? enumList;
List<Object?>? objectList;
List<List<Object?>?>? listList;
List<Map<Object?, Object?>?>? mapList;

// Maps
// ignore: strict_raw_type, always_specify_types
Expand All @@ -239,6 +255,8 @@ class AllNullableTypesWithoutRecursion {
Map<int?, int?>? intMap;
Map<AnEnum?, AnEnum?>? enumMap;
Map<Object?, Object?>? objectMap;
Map<int?, List<Object?>?>? listMap;
Map<int?, Map<Object?, Object?>?>? mapMap;
}

/// A class for testing nested class handling.
Expand Down
Loading