[flutter_adaptive_scaffold] Fix landscape not showing in andUp #7425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Renzo-Olivares can you check and approve? |
Contributor
|
FYI: flutter/flutter#153496 (comment)
|
kaboc
reviewed
Aug 17, 2024
|
@gspencergoog looks like changes were made. Are we good to go as a result? |
Contributor
Author
|
@Renzo-Olivares Can you check this too? |
11 tasks
Contributor
Author
|
@Renzo-Olivares Done! Can you check again? |
Contributor
Author
|
@Renzo-Olivares done. |
Contributor
Author
|
@Renzo-Olivares done. |
Renzo-Olivares
approved these changes
Aug 20, 2024
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2024
flutter/packages@4d2d2e3...4e5d47e 2024-08-21 [email protected] [webview_flutter] Endorse macOS (flutter/packages#7457) 2024-08-21 [email protected] [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425) 2024-08-20 [email protected] [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433) 2024-08-20 [email protected] Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459) 2024-08-20 [email protected] [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348) 2024-08-20 [email protected] [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@4d2d2e3...4e5d47e 2024-08-21 [email protected] [webview_flutter] Endorse macOS (flutter/packages#7457) 2024-08-21 [email protected] [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425) 2024-08-20 [email protected] [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433) 2024-08-20 [email protected] Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459) 2024-08-20 [email protected] [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348) 2024-08-20 [email protected] [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#153496
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.