[shared_preferences] fix cast error and mutable list error with getStringList
#7355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Aug 9, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM for the version that didn't add the deliberate failure.
...preferences/shared_preferences_windows/example/integration_test/shared_preferences_test.dart
Show resolved
Hide resolved
tarrinneal
added
the
autosubmit
|
Thanks. When can I expect the fix to release? |
Collaborator
Three days ago; we use a continuous release model for the packages in this repository. You just need to |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
…th `getStringList` (flutter/packages#7355)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
…th `getStringList` (flutter/packages#7355)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
…th `getStringList` (flutter/packages#7355)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
…th `getStringList` (flutter/packages#7355)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 12, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@f7b1256...d9a6de8 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/camera/camera_android/android (flutter/packages#7371) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.1 to 1.8.2 in /packages/path_provider/path_provider_android/android (flutter/packages#7376) 2024-08-12 [email protected] [pigeon] removes restriction on number of custom types per file (flutter/packages#6840) 2024-08-12 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370) 2024-08-12 [email protected] [shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335) 2024-08-12 [email protected] [flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300) 2024-08-12 [email protected] Manual roll Flutter from b12d861 to 9b84701 (8 revisions) (flutter/packages#7366) 2024-08-10 [email protected] Manual roll Flutter from 76107bd to b12d861 (14 revisions) (flutter/packages#7358) 2024-08-09 [email protected] [shared_preferences] fix cast error and mutable list error with `getStringList` (flutter/packages#7355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#153106
fixes flutter/flutter#153112
Will add a follow up pr adding a test to the top level package after this pr lands.