-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[flutter_adaptive_scaffold] Add expanded and extra large breakpoints #7300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
22cbbc2
Add expanded and extra large breakpoints
martijn00 7586c92
Add changelog
martijn00 e99918d
Readme
martijn00 ed51a0c
Add height based breakpoints
martijn00 eb39f84
Changelog
martijn00 44f2420
Fixes
martijn00 5d35bc5
Fix
martijn00 8bac3ff
Fixes
martijn00 95627eb
Tests
martijn00 1384775
Fix tests
martijn00 a1ff7d2
Clean
martijn00 3fc0a89
Update packages/flutter_adaptive_scaffold/README.md
martijn00 8951f11
Tests
martijn00 5f71bce
Set color in var
martijn00 89b34d0
Rename to mediumLarge
martijn00 2fb9d04
Fix test
martijn00 4410b62
Readme
martijn00 d6bed07
Update naming
martijn00 b3c7331
Cangelog
martijn00 1be9471
Rework breakpoint
martijn00 3e566ae
Readme
martijn00 c1fbe94
Changelog
martijn00 800be53
Fix
martijn00 7c6bfc0
Fix
martijn00 4573a54
Do changelog
martijn00 a368dab
Fix comments
martijn00 9c25616
Fix
martijn00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're still pre-1.0 here, no need to bump to 1.0, but since you're making breaking changes, you might want to bump to 0.2.0 and note the breaking changes in the CHANGELOG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the case, it would be great to make some more breaking changes hehe. I have some more ideas for bigger changes to align with Material specs. I would like to land those in smaller pieces in new PRs otherwise it would all just get one massive PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can take a look at those, but let's not put them in this PR. Best to keep the breaking changes in separate PRs so they can be more easily reverted if needed.
I didn't mean to suggest a field day for breaking changes. Let's still consider them on their merits before breaking people, even if it's a pre-1.0 package. But if they're worth it, by all means!