[interactive_media_ads] Adds support for all AdEventTypes and ad data
#7287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
AdEventTypes and ad data
stuartmorgan-g
approved these changes
Aug 7, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one nit.
| IOSAdsManagerDelegateCreationParams( | ||
| onAdEvent: expectAsync1((AdEvent event) { | ||
| expect(event.type, AdEventType.allAdsCompleted); | ||
| expect(event.adData, <String, String>{'hawk': 'tuah'}); |
Collaborator
There was a problem hiding this comment.
Please use hello and world in this file as well.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2024
flutter/packages@bb797b9...f7b1256 2024-08-09 [email protected] Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 [email protected] [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 [email protected] [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 [email protected] [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 [email protected] Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
flutter/packages@bb797b9...f7b1256 2024-08-09 [email protected] Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 [email protected] [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 [email protected] [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 [email protected] [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 [email protected] Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
flutter/packages@bb797b9...f7b1256 2024-08-09 [email protected] Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 [email protected] [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 [email protected] [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 [email protected] [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 [email protected] Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#152259
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.