Skip to content

[rfw][ci] Skip failing rfw golden tests #7170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[rfw][ci] Skip failing rfw golden tests #7170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fd4632
skipping test
LouiseHsu Jul 18, 2024
2e16f44
Merge branch 'main' into disable-rfw-goldens
LouiseHsu Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/rfw/test/argument_decoders_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/argument_decoders_test.containers.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
expect(find.byType(DecoratedBox), findsNWidgets(6));
const String matrix = kIsWeb ? '1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1'
Expand Down
24 changes: 18 additions & 6 deletions packages/rfw/test/material_widgets_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,19 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.scaffold.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

await tester.tap(find.byType(DropdownButton<Object>).first);
await tester.pumpAndSettle();
await expectLater(
find.byType(MaterialApp),
matchesGoldenFile('goldens/material_test.dropdown.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
// Tap on the second item.
await tester.tap(find.text('bar'));
Expand Down Expand Up @@ -289,7 +293,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.button_bar_properties.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

// Update the surface size for ButtonBar to overflow.
Expand Down Expand Up @@ -361,7 +367,9 @@ void main() {
find.byType(RemoteWidget),
matchesGoldenFile(
'goldens/material_test.overflow_bar_resembles_button_bar.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
});

Expand Down Expand Up @@ -436,7 +444,9 @@ void main() {
find.byType(RemoteWidget),
matchesGoldenFile(
'goldens/material_test.overflow_bar_properties.overflow.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);
});

Expand Down Expand Up @@ -566,7 +576,9 @@ void main() {
await expectLater(
find.byType(RemoteWidget),
matchesGoldenFile('goldens/material_test.material_properties.png'),
skip: !runGoldens,
// TODO(louisehsu): Unskip once golden file is updated. See
// https://github.com/flutter/flutter/issues/151995
skip: !runGoldens || true,
);

runtime.update(testName, parseLibraryFile('''
Expand Down