Remove package:platform source #6898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
stuartmorgan-g
approved these changes
Jun 10, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, but it seems like it would be good to publish a new version first so pub.dev isn't pointing people here for the source of the package.
Member
Author
|
Package has been published. Shall I wait until the tree failure is resolved before merging? |
stuartmorgan-g
added
the
autosubmit
Collaborator
|
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 12, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 [email protected] Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 [email protected] Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 [email protected] [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 [email protected] [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 [email protected] Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 [email protected] Remove package:platform source (flutter/packages#6898) 2024-06-10 [email protected] Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 [email protected] Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 [email protected] Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 [email protected] [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 [email protected] [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 [email protected] Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 [email protected] Remove package:platform source (flutter/packages#6898) 2024-06-10 [email protected] Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
flutter/packages@e95fe4a...8c24fd4 2024-06-11 [email protected] Roll Flutter from 32081aa to 14df7be (21 revisions) (flutter/packages#6907) 2024-06-11 [email protected] Ensure each code block specified in the markdown uses its own ScrollController. (flutter/packages#6904) 2024-06-10 [email protected] [video_player] Try to address test flake (flutter/packages#6899) 2024-06-10 [email protected] [ci] Allow `platform` references (flutter/packages#6903) 2024-06-10 [email protected] Change CODEOWNERS for metrics_center (flutter/packages#6892) 2024-06-10 [email protected] Remove package:platform source (flutter/packages#6898) 2024-06-10 [email protected] Roll Flutter from fc19ecf to 32081aa (9 revisions) (flutter/packages#6896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Package was removed in #6898. However the path was still being passed to dependabot, which made it mad: ``` ERROR <job_916983349> Error during file fetching; aborting: No files found in /packages/platform/example/android/app ``` https://github.com/flutter/packages/actions/runs/11845225387/job/33010210199 I don't understand why this only started failing on #8044 and not when the package was removed (since it moved that path from one place to another https://github.com/flutter/packages/pull/8036/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28L571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code for
package:platformhas been moved to https://github.com/dart-lang/platform/, see dart-archive/platform#46This PR removes the source from this repo, and leave a small cookie trail README in place.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.