Skip to content

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented May 22, 2024

And hard-codes filter qualities in tests to prepare for flutter/flutter#148799, which switches the default to medium. This hard-codes a filter quality in the test so the test passes no matter what the default is.

@goderbauer goderbauer requested a review from Hixie as a code owner May 22, 2024 17:24
@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label May 22, 2024
@goderbauer goderbauer changed the title [rfw] Hard-code FilterQuality in test [rfw] Adds support for DecorationImage.filterQuality. May 22, 2024
@goderbauer goderbauer requested a review from jonahwilliams May 22, 2024 18:23
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit auto-submit bot merged commit 79e4cbe into flutter:main May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2024
flutter/packages@6525441...1008d9e

2024-05-23 [email protected] Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786)
2024-05-23 [email protected] Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784)
2024-05-23 [email protected] [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755)
2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
2024-05-23 [email protected] Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780)
2024-05-23 [email protected] [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit to flutter/tests that referenced this pull request May 29, 2024
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@6525441...1008d9e

2024-05-23 [email protected] Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786)
2024-05-23 [email protected] Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784)
2024-05-23 [email protected] [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755)
2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
2024-05-23 [email protected] Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780)
2024-05-23 [email protected] [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants