[local_auth] Remove use of OCMock #6757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the iOS implementation of local_auth to use a protocol wrapping the relevant parts of `LAContext` instead of using `LAContext` directly, allowing the tests to use a stub implementation instead of OCMock. The goal is to unblock converting the unit tests to Swift, but even by itself this actually makes the tests much shorter and easier to understand. Part of flutter/flutter#119104
stuartmorgan-g
added
the
autosubmit
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Adjusts the iOS implementation of local_auth to use a protocol wrapping the relevant parts of `LAContext` instead of using `LAContext` directly, allowing the tests to use a stub implementation instead of OCMock. The goal is to unblock converting the unit tests to Swift, but even by itself this actually makes the tests much shorter and easier to understand. Part of flutter/flutter#119104
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 22, 2024
flutter/packages@ba19b24...6525441 2024-05-22 [email protected] [local_auth] Convert native unit tests to Swift (flutter/packages#6779) 2024-05-22 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.5.0 to 1.8.0 in /packages/interactive_media_ads/android (flutter/packages#6771) 2024-05-22 [email protected] [in_app_purchase_android] Introduced new ReplacementMode for Android's billing client (flutter/packages#6515) 2024-05-21 [email protected] [go_router] New feature improve debug full path (flutter/packages#6714) 2024-05-21 [email protected] [interactive_media_ads] Add SPM support (flutter/packages#6756) 2024-05-21 [email protected] Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter/packages#6778) 2024-05-21 [email protected] [local_auth] Remove use of OCMock (flutter/packages#6757) 2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.6 (flutter/packages#6777) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/file_selector/file_selector_android/android (flutter/packages#6769) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6765) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6762) 2024-05-20 [email protected] Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter/packages#6776) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
flutter/packages@ba19b24...6525441 2024-05-22 [email protected] [local_auth] Convert native unit tests to Swift (flutter/packages#6779) 2024-05-22 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump androidx.annotation:annotation from 1.5.0 to 1.8.0 in /packages/interactive_media_ads/android (flutter/packages#6771) 2024-05-22 [email protected] [in_app_purchase_android] Introduced new ReplacementMode for Android's billing client (flutter/packages#6515) 2024-05-21 [email protected] [go_router] New feature improve debug full path (flutter/packages#6714) 2024-05-21 [email protected] [interactive_media_ads] Add SPM support (flutter/packages#6756) 2024-05-21 [email protected] Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter/packages#6778) 2024-05-21 [email protected] [local_auth] Remove use of OCMock (flutter/packages#6757) 2024-05-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.6 (flutter/packages#6777) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/file_selector/file_selector_android/android (flutter/packages#6769) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#6765) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.7.1 to 1.8.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#6762) 2024-05-20 [email protected] Roll Flutter from adf279f to 02a6c91 (8 revisions) (flutter/packages#6776) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the iOS implementation of local_auth to use a protocol wrapping the relevant parts of
LAContextinstead of usingLAContextdirectly, allowing the tests to use a stub implementation instead of OCMock.The goal is to unblock converting the unit tests to Swift, but even by itself this actually makes the tests much shorter and easier to understand.
Part of flutter/flutter#119104
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).