Skip to content

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented May 15, 2024

Adds notes in the camera/camera and camera/camera_android_cameraX READMEs about the used WRITE_EXTERNAL_STORAGE permission used in the plugin and the foreground service permission that is required to specify if you wish to allow image streaming in the background.

Fixes flutter/flutter#146935 and addresses flutter/flutter#131116 (comment).

Pre-launch Checklist

@camsim99 camsim99 marked this pull request as ready for review May 16, 2024 17:21
@camsim99 camsim99 requested a review from bparrishMines as a code owner May 16, 2024 17:21
@camsim99 camsim99 requested a review from stuartmorgan-g May 16, 2024 17:21
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
Copy link
Contributor

auto-submit bot commented May 29, 2024

auto label is removed for flutter/packages/6741, due to Pull request flutter/packages/6741 is not in a mergeable state.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit auto-submit bot merged commit d3b60e5 into flutter:main May 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2024
flutter/packages@31d3329...910fabb

2024-05-29 [email protected] Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 [email protected] Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 [email protected] [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 [email protected] Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 [email protected] Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 [email protected] [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 [email protected] [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 [email protected] [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 [email protected] Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 [email protected] [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 [email protected] [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@31d3329...910fabb

2024-05-29 [email protected] Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 [email protected] Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 [email protected] [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 [email protected] Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 [email protected] Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 [email protected] [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 [email protected] [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 [email protected] [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 [email protected] Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 [email protected] [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 [email protected] [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android][camera] Update documentation to note how to allow image streaming in the background
3 participants