Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 14, 2024

This test has started failing consistently on post-submit. See flutter/flutter#148345

@bparrishMines bparrishMines requested a review from cbracken as a code owner May 14, 2024 20:01
@bparrishMines bparrishMines changed the title skip the test [webview_flutter_wkwebview] Skip withWeakReferenceTo integration test May 14, 2024
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels May 14, 2024
@auto-submit auto-submit bot merged commit abc3d07 into flutter:main May 14, 2024
@bparrishMines bparrishMines deleted the skiperoo branch May 14, 2024 21:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2024
flutter/packages@fd714bd...87a02e3

2024-05-15 [email protected] Roll Flutter from d2da1b2 to 39651e8 (18 revisions) (flutter/packages#6738)
2024-05-15 [email protected] Update the repo for the 3.22 stable release (flutter/packages#6730)
2024-05-15 [email protected] [webview_flutter_wkwebview] Fixes JSON.stringify() cannot serialize cyclic structures (flutter/packages#6274)
2024-05-14 [email protected] [in_app_purchase_storekit] migrate main plugin class to swift in preperation to storekit 2 (flutter/packages#6561)
2024-05-14 [email protected] [image_picker_android] Refactor getting of paths from intent to single helper (flutter/packages#5009)
2024-05-14 [email protected] Roll Flutter (stable) from 54e6646 to 5dcb86f (1402 revisions) (flutter/packages#6727)
2024-05-14 [email protected] [webview_flutter_wkwebview] Skip `withWeakReferenceTo` integration test (flutter/packages#6731)
2024-05-14 [email protected] Roll Flutter from 1255435 to d2da1b2 (26 revisions) (flutter/packages#6729)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…st (flutter#6731)

This test has started failing consistently on post-submit. See flutter/flutter#148345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: webview_flutter platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants