Skip to content

Conversation

vashworth
Copy link
Contributor

Makes shared_preferences_foundation available as a Swift Package to Flutter. Also, remains compatible with CocoaPods.

Fixes flutter/flutter#146918.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth marked this pull request as ready for review May 6, 2024 20:22
@vashworth vashworth requested a review from tarrinneal as a code owner May 6, 2024 20:22
@vashworth vashworth requested review from stuartmorgan-g and removed request for tarrinneal May 6, 2024 20:22
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2024
@auto-submit auto-submit bot merged commit 5ccddfc into flutter:main May 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 7, 2024
flutter/packages@2dfe645...5ccddfc

2024-05-06 [email protected] [shared_preferences_foundation] Adds Swift Package Manager compatibility (flutter/packages#6640)
2024-05-06 [email protected] [file_selector] Add support for SPM (flutter/packages#6672)
2024-05-06 [email protected] [camerax] Add empty implementation for `prepareForVideoRecording` not used on Android (flutter/packages#6676)
2024-05-06 [email protected] [ci] Reduce the number of tasks in recipe CQ (flutter/packages#6673)
2024-05-06 [email protected] Roll Flutter from f1037a0 to 04424e1 (25 revisions) (flutter/packages#6674)
2024-05-06 [email protected] [camerax] Prevent using unsupported concurrent camera use cases (flutter/packages#6608)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
…ity (flutter#6640)

Makes `shared_preferences_foundation` available as a Swift Package to Flutter. Also, remains compatible with CocoaPods.

Fixes flutter/flutter#146918.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: shared_preferences platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shared_preferences_foundation] Add Swift Package Manager compatibility to shared_preferences_foundation
2 participants