[google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. #6430
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
added
emergency
Member
Author
|
A proper fix for this issue is coming here: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 29, 2024
flutter/packages@924c7e6...51faaa1 2024-03-29 [email protected] [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332) 2024-03-29 [email protected] Manual roll Flutter (stable) from 68bfaea to 300451a (2 revisions) (flutter/packages#6433) 2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705) 2024-03-28 [email protected] Manual roll Flutter from dbdcead to 89ea492 (54 revisions) (flutter/packages#6431) 2024-03-28 [email protected] [ci] Adds sleep 60s to release action. (flutter/packages#6405) 2024-03-28 [email protected] [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236) 2024-03-28 [email protected] [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060" (flutter/packages#6425) 2024-03-28 [email protected] [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily pins the GoogleSignIn iOS SDK to version 7.0.0 in the darwin podspec configuration.
This'll enable our CI to keep going, until a more proper fix to
google_sign_in_ioslands, with an update to the latest 7.1 version. See:For more information about the current CI failures.
Testing
This PR should help with the tests that are currently broken in CI.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.