[webview_flutter_android] Add javascript panel interface for android #5796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharp83
force-pushed
the
add-javascript-panel-interface-android
branch
from
e65dc03 to
25b6ecd
Compare
jsharp83
force-pushed
the
add-javascript-panel-interface-android
branch
from
25b6ecd to
45599ba
Compare
There was a problem hiding this comment.
This is now waiting on #5901, but is still ready for secondary review.
11 tasks
jsharp83
force-pushed
the
add-javascript-panel-interface-android
branch
from
018404a to
5988770
Compare
stuartmorgan-g
approved these changes
Jan 23, 2024
|
This is no longer blocked since #5901 is a breaking change as mentioned in #5901 (comment). So, the current interface method will have to stay and I or someone else will add the nullable method after this has landed so we can have access to all the wrapped native APIs. |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
flutter/packages@8fbdf65...21b5abb 2024-01-24 [email protected] Add rfw widgets (flutter/packages#5661) 2024-01-24 [email protected] [camera] add heif support image iOS (flutter/packages#4586) 2024-01-24 [email protected] [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796) 2024-01-24 [email protected] [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659) 2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967) 2024-01-24 [email protected] Roll Flutter from 5b673c2 to 19b06f4 (21 revisions) (flutter/packages#5968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where Web calls System Popup with javascript on webview_flutter
Android has a interface on WebChromeClient
Related issue: alert() method doesn't work in WebView flutter#30358 (comment)
Related Interface PR: [webview_flutter] Implement platform interface for JavaScript dialog #5670
The PR that contains all changes can be found at [webview_flutter] Add interface for showing javascript dialog message #4704
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.