Skip to content

[espresso] Replace deprecated getObservatoryUri #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[espresso] Replace deprecated getObservatoryUri #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c72065b
[espresso] Replace deprecated `getObservatoryUri`
stuartmorgan-g Jan 3, 2024
647a3c6
Merge branch 'main' into espresso-deprecation-fix
stuartmorgan-g Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/espresso/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT
## 0.3.0+7

* Replaces call to deprecated `getObservatoryUri`.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 0.3.0+6
Expand Down
4 changes: 1 addition & 3 deletions ...presso/android/src/main/java/androidx/test/espresso/flutter/action/FlutterViewAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,8 @@ public void perform(UiController uiController, View flutterView) {
// The url {@code FlutterNativeView} returns is the http url that the Dart VM Observatory http
// server serves at. Need to convert to the one that the WebSocket uses.

// TODO(stuartmorgan): migrate to getVMServiceUri() once that is available on stable.
@SuppressWarnings("deprecation")
URI dartVmServiceProtocolUrl =
DartVmServiceUtil.getServiceProtocolUri(FlutterJNI.getObservatoryUri());
DartVmServiceUtil.getServiceProtocolUri(FlutterJNI.getVMServiceUri());
String isolateId = DartVmServiceUtil.getDartIsolateId(flutterView);
final FlutterTestingProtocol flutterTestingProtocol =
new DartVmService(
Expand Down
2 changes: 1 addition & 1 deletion packages/espresso/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Java classes for testing Flutter apps using Espresso.
Allows driving Flutter widgets from a native Espresso test.
repository: https://github.com/flutter/packages/tree/main/packages/espresso
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22
version: 0.3.0+6
version: 0.3.0+7

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down