Skip to content

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jan 2, 2024

Fixes flutter/flutter#139937 and updates all references to ActivityPluginBinding and its related Activity as it is attached/re-attached/detached.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@camsim99 camsim99 marked this pull request as ready for review January 11, 2024 22:36
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2024
@auto-submit auto-submit bot merged commit ad79b99 into flutter:main Jan 22, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2024
flutter/packages@e4cbf23...841fe90

2024-01-22 [email protected] [two_dimensional_scrollables] Fix TableSpanDecoration rects when axes are reversed (flutter/packages#5916)
2024-01-22 [email protected] [most on Android] Bump compile SDK version to 34 (flutter/packages#5783)
2024-01-22 [email protected] [url_launcher]: Fix a grammar error in the comments of launchUrl method (flutter/packages#5919)
2024-01-22 [email protected] [webview_platform_interface] Adds WebResourceRequest to HttpResponseError (flutter/packages#5790)
2024-01-22 [email protected] [camerax] Update `Activity` references when `ActivityAware` lifecycle methods called (flutter/packages#5784)
2024-01-22 [email protected] Roll Flutter from 5dea6b9 to 3ee8ff2 (9 revisions) (flutter/packages#5955)
2024-01-22 [email protected] [espresso] Replace deprecated `getObservatoryUri` (flutter/packages#5788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camerax] Remove references to Activitys when plugin is detached
2 participants