[pigeon] Adds @CanIgnoreReturnValue annotation #5601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
changed the title
tarrinneal
changed the title
kluever
reviewed
Dec 7, 2023
|
|
||
| @Target(METHOD) | ||
| @Retention(CLASS) | ||
| @interface CanIgnoreReturnValue {} |
There was a problem hiding this comment.
Thoughts about also emitting a CheckReturnValue annotation on the enclosing type? (That also means generating a CRV annotation as well)
Contributor
Author
There was a problem hiding this comment.
If you think it's a valuable addition, I can look into it.
There was a problem hiding this comment.
It won't help internal Google users (we have CRV by default), but any external users who are using static analysis would definitely benefit the addition of @CheckReturnValue on the enclosing type. (That being said, it can be done later, so a TODO is also fine.)
Contributor
Author
There was a problem hiding this comment.
I think we'll wait for now. If there are users who are interested in this being added, I encourage you to file an issue (or throw up a quick pr!).
stuartmorgan-g
approved these changes
Dec 12, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one added comment.
tarrinneal
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/5601, due to - The status or check suite Linux_android custom_package_tests stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2023
flutter/packages@80aa46a...b5958e2 2023-12-13 [email protected] [camera, camera_android] Re-enable passing integration tests (flutter/packages#5658) 2023-12-13 [email protected] Roll Flutter from 9719097 to 11a9cb7 (32 revisions) (flutter/packages#5665) 2023-12-13 [email protected] [url_launcher] Return false on Windows when there is no handler (flutter/packages#5359) 2023-12-13 [email protected] [url_launcher] Simplify Linux implementation (flutter/packages#5376) 2023-12-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.6.1 to 1.6.2 in /packages/local_auth/local_auth_android/android (flutter/packages#5332) 2023-12-12 [email protected] [pigeon] Adds @CanIgnoreReturnValue annotation (flutter/packages#5601) 2023-12-12 [email protected] [image_picker] updates to resize logic. (flutter/packages#5527) 2023-12-12 [email protected] [various] Update examples using video_player (flutter/packages#5653) 2023-12-12 [email protected] [tools] Validate pubspec topic format (flutter/packages#5565) 2023-12-12 [email protected] [pigeon] Fix Kotlin generator to use provided errorClassName (flutter/packages#5480) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds @CanIgnoreReturnValue annotation to java class builder method
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.