Skip to content

Conversation

ditman
Copy link
Member

@ditman ditman commented Dec 6, 2023

  • Migrates package to use package:web so it can be compiled with WASM.
  • Breaking change: Addresses API mismatches with the latest JS SDK changes.
  • Adds some tests to client configuration objects.

(See CHANGELOG.md for a more thorough list of changes)

Issues

Tests

  • Ran unit/integration tests locally, added a couple more.
  • Tested example apps with flutter run, both seem to work.
  • Tested example apps with --wasm, both seem to work.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman force-pushed the gis-web-sdk-to-pkg-web branch from 8a3970a to fe62794 Compare December 6, 2023 23:01
@ditman ditman force-pushed the gis-web-sdk-to-pkg-web branch from 8feab8b to 0c1e1c3 Compare December 7, 2023 01:39
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2023
@auto-submit auto-submit bot merged commit 15584a3 into flutter:main Dec 7, 2023
@ditman ditman deleted the gis-web-sdk-to-pkg-web branch December 7, 2023 06:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 7, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 7, 2023
flutter/packages@ca16173...15584a3

2023-12-07 [email protected] [gis_web] Migrate to package:web. (flutter/packages#5581)
2023-12-07 [email protected] Drop quiver usage in several packages (flutter/packages#5595)
2023-12-07 [email protected] [video_player] Unfork publish: for macOS (flutter/packages#5578)
2023-12-07 [email protected] [web_benchmarks] migrate to pkg:web (flutter/packages#5592)
2023-12-07 [email protected] [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598)
2023-12-06 [email protected] [animations] Bump minimum Flutter version (flutter/packages#5596)
2023-12-06 [email protected] Migrate Material curves to new names (flutter/packages#4898)
2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591)
2023-12-06 [email protected] [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500)
2023-12-06 [email protected] [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536)
2023-12-06 [email protected] Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577)
2023-12-06 [email protected] [google_sign_in] Add macOS support (flutter/packages#4962)
2023-12-06 [email protected] [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google_identity_services_web] migrate to pkg:web [gis_web] Client configuration values are out of sync with API.
5 participants