Skip to content

[go_router] fix(docs): typo in example extra_codec.dart #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[go_router] fix(docs): typo in example extra_codec.dart #5570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc93bd
fix(docs): typo in example extra_codec.dart
ndelanou Dec 5, 2023
113eaff
add invalid extra_codec test
ndelanou Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/go_router/example/lib/extra_codec.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class _MyExtraDecoder extends Converter<Object?, Object?> {
if (inputAsList[0] == 'ComplexData2') {
return ComplexData2(inputAsList[1]! as String);
}
throw FormatException('Unable tp parse input: $input');
throw FormatException('Unable to parse input: $input');
}
}

Expand Down
16 changes: 16 additions & 0 deletions packages/go_router/example/test/extra_codec_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,20 @@ void main() {
expect(find.text('The extra for this page is: ComplexData2(data: data)'),
findsOneWidget);
});

test('invalid extra throws', () {
const example.MyExtraCodec extraCodec = example.MyExtraCodec();
const List<Object?> invalidValue = <Object?>['invalid'];

expect(
() => extraCodec.decode(invalidValue),
throwsA(
predicate(
(Object? exception) =>
exception is FormatException &&
exception.message == 'Unable to parse input: $invalidValue',
),
),
);
});
}