Skip to content

[file_selector] Remove deprecated primary and onPrimary references from ElevatedButton.styleFrom #5566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2023
Merged

[file_selector] Remove deprecated primary and onPrimary references from ElevatedButton.styleFrom #5566

merged 2 commits into from
Dec 5, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Dec 4, 2023 •
edited
Loading

This PR is to remove deprecated primary and onPrimary references(deprecation PR) from ElevatedButton.styleFrom.

primary should be replaced with backgroundColor and onPrimary should be replaced with foregroundColor.

No new tests needed. Please let me know if I incorrectly handled the CHANGELOG and version change.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@QuncCccccc QuncCccccc changed the title Remove deprecated primary and onPrimary references from ElevatedButton.styleFrom [file_selector] Remove deprecated primary and onPrimary references from ElevatedButton.styleFrom Dec 4, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review December 4, 2023 23:24
@QuncCccccc QuncCccccc requested a review from cbracken as a code owner December 4, 2023 23:24
stuartmorgan-g
stuartmorgan-g requested changes Dec 5, 2023
View reviewed changes
packages/file_selector/file_selector_macos/CHANGELOG.md Outdated
## NEXT
## 0.9.3+4

* Remove deprecated `primary` and `onPrimary` references from `ElevatedButton.styleFrom`.
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't need changelog or version entries; they are to non-main example files so fall under the second exemption.

Copy link
Contributor Author

@QuncCccccc QuncCccccc Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for helping review! I just reverted the change for changelog and the version entires!

@QuncCccccc QuncCccccc force-pushed the remove_deprecated_api_references branch from e6b1a4f to 4bc6a3f Compare December 5, 2023 17:20
@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 5, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@QuncCccccc QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Dec 5, 2023
@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Dec 5, 2023

test-exempt: code refactor with no semantic change

stuartmorgan-g
stuartmorgan-g approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Dec 5, 2023

There's unfortunately an issue where re-running repo_checks isn't picking up new labels, so you'll need to do something like force-push.

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Dec 5, 2023

There's unfortunately an issue where re-running repo_checks isn't picking up new labels, so you'll need to do something like force-push.

Ah I see. Just re-triggered the tests! Thanks!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit bot merged commit 8be3268 into main Dec 5, 2023
@auto-submit auto-submit bot deleted the remove_deprecated_api_references branch December 5, 2023 18:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
8be3268 [file_selector] Remove deprecated primary and onPrimary r…
2b524be 
…eferences from `ElevatedButton.styleFrom` (flutter/packages#5566)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
Roll Packages from 4e7f160 to ca16173 (3 revisions) (#139661)
1f07909 
flutter/packages@4e7f160...ca16173

2023-12-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Bump actions/labeler from 4.3.0 to 5.0.0" (flutter/packages#5579)
2023-12-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.3.0 to 5.0.0 (flutter/packages#5568)
2023-12-05 [email protected] [file_selector] Remove deprecated `primary` and `onPrimary` references from `ElevatedButton.styleFrom` (flutter/packages#5566)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: file_selector platform-macos platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@QuncCccccc @stuartmorgan-g