-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[multicast_dns] Adjust README #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multicast_dns] Adjust README #5529
Conversation
- Improves link targets to be more directly useful. - Removes the unnecessary code sections showing an import, since the install tab already demonstrates that. - Removes the no-longer-needed exemption from the excerpt requirement. Part of flutter/flutter#102679
tarrinneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've really managed to fail a lot of tests for a readme update!
I started looking at a system that would let us be smarter about what tests we run when we touch a script/config/ file, but it's non-trivial and I haven't had time to really dig in. So for now we're stuck with this situation where it runs everything :| |
|
auto label is removed for flutter/packages/5529, due to - The status or check suite Windows_x64 dart_unit_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
auto label is removed for flutter/packages/5529, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@6cd0657...cb6dbcd 2023-12-09 [email protected] [multicast_dns] Adjust README (flutter/packages#5529) 2023-12-09 [email protected] [tool] Use ^ for Dart SDK (flutter/packages#5623) 2023-12-09 [email protected] [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612) 2023-12-08 [email protected] [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629) 2023-12-08 [email protected] Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614) 2023-12-08 [email protected] [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619) 2023-12-08 [email protected] [ci] Fix indentation in labeler.yml (flutter/packages#5625) 2023-12-08 [email protected] Update labeler to 5.0.0, fix yml format (flutter/packages#5580) 2023-12-08 [email protected] [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#102679
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).