[cupertino_icons] Add example to cupertino icons #5312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Nov 4, 2023
There was a problem hiding this comment.
This adds a large amount of boilerplate, and doesn't appear to offer any benefits that https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html doesn't. An example/example.md file that links to https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html seems like it would achieve the goals of the linked issue in a much simpler way.
|
Okay @stuartmorgan I will update this PR to remove the app & add an example.md file which links to the documentation. |
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
from
86a6c9f to
fb8daf3
Compare
|
@stuartmorgan I have updated the PR. Please review. |
stuartmorgan-g
requested changes
Nov 6, 2023
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
3 times, most recently
from
46cedc2 to
a365fd4
Compare
stuartmorgan-g
requested changes
Nov 29, 2023
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
2 times, most recently
from
787b811 to
3a76ff3
Compare
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
2 times, most recently
from
0a2746d to
d779fa6
Compare
stuartmorgan-g
requested changes
Dec 14, 2023
third_party/packages/cupertino_icons/test/cupertino_icons_test.dart
Outdated
Show resolved
Hide resolved
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
from
d779fa6 to
f977c41
Compare
|
Once #5775 is reviewed and landed, merge |
Okay @stuartmorgan |
|
The failure this time is something that needs to be fixed in the PR due to a recently enabled lint; see https://github.com/flutter/packages/pull/5717/files#diff-86bbf9121116e918f9f79ccbb484b1d77358f1a30f092129f30333542f614c75 for an example of a fix for the same lint. |
Major sections should follow standard repository ordering:
environment:
dependencies:
dev_dependencies:
flutter:
topics:
screenshots:
false_secrets:
foxtrotravi
force-pushed
the
add_example_to_cupertino_icons
branch
from
6a2025b to
3f24c60
Compare
|
@stuartmorgan please review |
stuartmorgan-g
approved these changes
Feb 12, 2024
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2024
flutter/packages@0a69259...9385bbb 2024-02-13 [email protected] Convert startProductRequest(), finishTransaction(), restoreTransactions(), presentCodeRedemptionSheet() to pigeon (flutter/packages#6032) 2024-02-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20231013 to 20240205 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6096) 2024-02-12 [email protected] [local_auth] Rename iOS classes (flutter/packages#6108) 2024-02-12 [email protected] [video_player_android] Handle BehindLiveWindowException (flutter/packages#5869) 2024-02-12 [email protected] [in_app_purchase] Add alternative billing apis for android (flutter/packages#6056) 2024-02-12 [email protected] [webview_flutter] Update compileSdk to 34 (flutter/packages#6106) 2024-02-12 [email protected] [cupertino_icons] Add example to cupertino icons (flutter/packages#5312) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR:
Adding an example app to showcase the usage of
cupertino_icons. This addition will also increase the pub points of the package and will be helpful for other developers to quickly find relevant examples.Fixes flutter/flutter#137682
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).