Skip to content

[in_app_purchase_android] Add missing response code to BillingResponse enum #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2023
Merged

[in_app_purchase_android] Add missing response code to BillingResponse enum #5120

merged 7 commits into from
Oct 30, 2023

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Oct 11, 2023 •
edited
Loading

This response code was missing.

Fixes flutter/flutter#135540

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review October 11, 2023 18:55
@putnokiabel

This comment was marked as off-topic.

Sign in to view
@gmackall gmackall requested review from a team and bparrishMines October 26, 2023 21:41
@chenenyu

This comment was marked as off-topic.

Sign in to view
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2023
@auto-submit auto-submit bot merged commit b236d83 into flutter:main Oct 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2023
@engine-flutter-autoroll
b236d83 [in_app_purchase_android] Add missing response code to Billin…
dce7a99 
…gResponse enum (flutter/packages#5120)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 31, 2023
@engine-flutter-autoroll
Roll Packages from 2af6954 to c9fec61 (12 revisions) (#137623)
61225b9 
flutter/packages@2af6954...c9fec61

2023-10-31 [email protected] [image_picker] Prevent multiple active calls on iOS (flutter/packages#5272)
2023-10-30 [email protected] [in_app_purchase_android] Add missing response code to BillingResponse enum (flutter/packages#5120)
2023-10-30 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.4 to 2.22.5 (flutter/packages#5263)
2023-10-30 [email protected] Bump play-service-maps dependency from version 18.1.0 to 18.2.0 (flutter/packages#5243)
2023-10-30 [email protected] Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (flutter/packages#5267)
2023-10-30 [email protected] [camerax] Loosen restrictions of fallback strategies for choosing resolutions (flutter/packages#5239)
2023-10-30 [email protected] [pigeon] Don't wrap non-nullable primitives in Obj-C (flutter/packages#5214)
2023-10-30 [email protected] [flutter_lints] Replace "flutter pub add --dev" with "dev:" (flutter/packages#5260)
2023-10-28 [email protected] Roll Flutter from 5907c97 to a4ec627 (18 revisions) (flutter/packages#5255)
2023-10-27 [email protected] [go_router] Fixes deep-link with no path on cold start (flutter/packages#5113)
2023-10-27 [email protected] [two_dimensional_scrollables] Fix pinned row painting when one axis is reversed (flutter/packages#5187)
2023-10-27 [email protected] Roll Flutter from c555599 to 5907c97 (45 revisions) (flutter/packages#5252)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Oct 31, 2023
@engine-flutter-autoroll @ksokolovskyi
Roll Packages from 2af6954 to c9fec61 (12 revisions) (flutter#137623)
e8eaac1 
flutter/packages@2af6954...c9fec61

2023-10-31 [email protected] [image_picker] Prevent multiple active calls on iOS (flutter/packages#5272)
2023-10-30 [email protected] [in_app_purchase_android] Add missing response code to BillingResponse enum (flutter/packages#5120)
2023-10-30 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.4 to 2.22.5 (flutter/packages#5263)
2023-10-30 [email protected] Bump play-service-maps dependency from version 18.1.0 to 18.2.0 (flutter/packages#5243)
2023-10-30 [email protected] Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (flutter/packages#5267)
2023-10-30 [email protected] [camerax] Loosen restrictions of fallback strategies for choosing resolutions (flutter/packages#5239)
2023-10-30 [email protected] [pigeon] Don't wrap non-nullable primitives in Obj-C (flutter/packages#5214)
2023-10-30 [email protected] [flutter_lints] Replace "flutter pub add --dev" with "dev:" (flutter/packages#5260)
2023-10-28 [email protected] Roll Flutter from 5907c97 to a4ec627 (18 revisions) (flutter/packages#5255)
2023-10-27 [email protected] [go_router] Fixes deep-link with no path on cold start (flutter/packages#5113)
2023-10-27 [email protected] [two_dimensional_scrollables] Fix pinned row painting when one axis is reversed (flutter/packages#5187)
2023-10-27 [email protected] Roll Flutter from c555599 to 5907c97 (45 revisions) (flutter/packages#5252)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmccutchan johnmccutchan johnmccutchan approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchase] _$BillingResponseEnumMap doesn't contain the NETWORK_ERROR (Error Code 12)

4 participants

@gmackall @putnokiabel @chenenyu @johnmccutchan