[go_router] Fixes missing state.extra in onException() #5077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-hyj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@7de08ec...4b483f2 2023-10-10 [email protected] Run tests on either macOS 12 or macOS 13 (flutter/packages#5089) 2023-10-10 [email protected] [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085) 2023-10-09 [email protected] [process] Import the `process` package (flutter/packages#5095) 2023-10-09 [email protected] [go_router] Fixes missing state.extra in onException() (flutter/packages#5077) 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094) 2023-10-09 [email protected] Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093) 2023-10-09 [email protected] [platform] Example app for platform (flutter/packages#4834) 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
flutter/packages@7de08ec...4b483f2 2023-10-10 [email protected] Run tests on either macOS 12 or macOS 13 (flutter/packages#5089) 2023-10-10 [email protected] [google_map_flutter_ios] fix `didBeginDraggingMarker` typo (flutter/packages#5085) 2023-10-09 [email protected] [process] Import the `process` package (flutter/packages#5095) 2023-10-09 [email protected] [go_router] Fixes missing state.extra in onException() (flutter/packages#5077) 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.0 to 2.22.1 (flutter/packages#5094) 2023-10-09 [email protected] Roll Flutter from 5207a30 to f52fe4f (18 revisions) (flutter/packages#5093) 2023-10-09 [email protected] [platform] Example app for platform (flutter/packages#4834) 2023-10-09 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.2.0 to 2.3.0 (flutter/packages#5091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help in knowing the extra Object passed when the non-existing-location was asked.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.