Skip to content

[flutter_markdown] Code decoration #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2023
Merged

[flutter_markdown] Code decoration #5060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c1ac5be
[flutter_markdown] Replace DecoratedBox by Container for pre tag
dawidope Oct 2, 2023
adb547f
[flutter_markdown] Clip code block content for set border radius
dawidope Oct 2, 2023
5443c46
[flutter_markdown] Replace ClipRRect by clipBehavior
dawidope Oct 2, 2023
0a88873
[flutter_markdown] Add changelog and bump version
dawidope Oct 2, 2023
222f2f5
[flutter_markdown] Fix unnecessary use of a null check
dawidope Oct 2, 2023
ca3cc74
[flutter_markdown] Make changelog more specific
dawidope Oct 2, 2023
9904ba4
[flutter_markdown] Make changelog more specific
dawidope Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/flutter_markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.17+4

* Fixes an issue where a code block would overlap its container decoration.

## 0.6.17+3

* Fixes an incorrect note about SDK versions in the 0.6.17+2 CHANGELOG.md entry.
Expand Down
5 changes: 3 additions & 2 deletions packages/flutter_markdown/lib/src/builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,9 @@ class MarkdownBuilder implements md.NodeVisitor {
),
);
} else if (tag == 'pre') {
child = DecoratedBox(
decoration: styleSheet.codeblockDecoration!,
child = Container(
clipBehavior: Clip.hardEdge,
decoration: styleSheet.codeblockDecoration,
child: child,
);
} else if (tag == 'hr') {
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_markdown/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Markdown renderer for Flutter. Create rich text output,
formatted with simple Markdown tags.
repository: https://github.com/flutter/packages/tree/main/packages/flutter_markdown
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_markdown%22
version: 0.6.17+3
version: 0.6.17+4

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down