[tool] Add option for Android compile SDK version to update-dependencies command #5010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
commented
Oct 23, 2023
stuartmorgan-g
approved these changes
Oct 31, 2023
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with minor changes.
| return true; | ||
| } | ||
| } | ||
| return false; |
Collaborator
There was a problem hiding this comment.
Optional: Everything from 153 to here could collapse to:
// Check whether this is one of the enclosing package's examples.
return enclosingPackage.getExamples().any((RepositoryPackage p) => p.path == path);
Contributor
Author
There was a problem hiding this comment.
Oooo this is neat!
| _AndroidDepdencyType.compileSdk: | ||
| 'Updates compileSdk version used to compile plugins.', | ||
| _AndroidDepdencyType.compileSdkForExamples: | ||
| 'Updates compileSdk version used to compile plugin examples', |
Collaborator
There was a problem hiding this comment.
Nit: This is missing the . that the others have.
| ]); | ||
| } | ||
|
|
||
| Future<PackageResult> _runForAndroidDependencyOnExample( |
| example.platformDirectory(FlutterPlatform.android); | ||
| File? fileToUpdate; | ||
| RegExp? dependencyVersionPattern; | ||
| String? newDependencyVersionEntry; |
Collaborator
There was a problem hiding this comment.
These should be final and non-nullable, and the if/else if chain should have an else that throws. Then you won't need to force-unwrap these later, and the compiler will enforce that they are set in every branch.
Contributor
Author
There was a problem hiding this comment.
This is actually super good to know, thank you!!
camsim99
added
the
autosubmit
PROGrand
pushed a commit
to mtbo-org/packages
that referenced
this pull request
Nov 1, 2023
…ies command (flutter#5010) Adds option to `update-dependencies` command to update the compile SDK version of plugins or their example apps.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2023
…ependencies command (flutter/packages#5010)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2023
…ependencies command (flutter/packages#5010)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 1, 2023
flutter/packages@c9fec61...6ad40b9 2023-11-01 [email protected] Roll Flutter from e12d1a7 to 29b2516 (34 revisions) (flutter/packages#5290) 2023-11-01 [email protected] [file_selector] Updates iOS to Pigeon 13 (flutter/packages#5268) 2023-10-31 [email protected] [camera_avfoundation] � Fix inverted orientation strings (flutter/packages#5261) 2023-10-31 [email protected] [tool] Add option for Android compile SDK version to update-dependencies command (flutter/packages#5010) 2023-10-31 [email protected] [video_player] Update iOS/macOS to Pigeon 13 (flutter/packages#5270) 2023-10-31 [email protected] [video_player] Update example app to replace `ButtonBar` with `OverflowBar` (flutter/packages#5274) 2023-10-31 [email protected] [image_picker] Update iOS to Pigeon 13 (flutter/packages#5266) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to
update-dependenciescommand to update the compile SDK version of plugins or their example apps.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).