Skip to content

Conversation

LongCatIsLooong
Copy link
Contributor

Migrate ImageProvider.load to ImageProvider.loadImage.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 15, 2023

auto label is removed for flutter/packages/4720, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2023
@auto-submit auto-submit bot merged commit 0b4e9e3 into main Aug 15, 2023
@auto-submit auto-submit bot deleted the LongCatIsLooong-migrate-ImageProvider branch August 15, 2023 23:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 16, 2023
flutter/packages@84218b9...9bf208f

2023-08-16 [email protected] Manual roll Flutter from 9b6945b to f0e7c51 (63 revisions) (flutter/packages#4719)
2023-08-15 [email protected] Update palette_generator_test.dart (flutter/packages#4720)
2023-08-15 [email protected] [pigeon] Fix typo in README.md (flutter/packages#4707)
2023-08-15 [email protected] [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716)
2023-08-15 [email protected] [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563)
2023-08-15 [email protected] [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620)
2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: palette_generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants