Skip to content

Conversation

eriko13
Copy link
Contributor

@eriko13 eriko13 commented Jul 24, 2023

Created a demo app for the xdg_directories package to showcase some of the basic functionalities.

Screenshot 2023-08-01 at 11 45 31 a m

Fixes: #128698

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@eriko13
Copy link
Contributor Author

eriko13 commented Aug 1, 2023

@stuartmorgan the PR is ready for another review. Here's a new screenshot:

Thanks for your comments.

Screenshot 2023-08-01 at 11 45 31 a m

@eriko13 eriko13 requested a review from stuartmorgan-g August 1, 2023 18:55
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@gspencergoog Could you do the second review on this?

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2023
@stuartmorgan-g
Copy link
Collaborator

@eriko13 It's not necessary to constantly re-merge main; it's extremely unlikely that anything on main would affect this PR. It will land automatically when the tree re-opens.

@eriko13
Copy link
Contributor Author

eriko13 commented Aug 7, 2023

@stuartmorgan Sorry!

I thought I had to re-merge /main so the submit-queue check could refresh.

Got it, I'll leave it as is.

Thanks!

@auto-submit auto-submit bot merged commit 0042da7 into flutter:main Aug 8, 2023
@eriko13 eriko13 deleted the xdg_directories/add-example-app branch August 8, 2023 02:07
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2023
flutter/packages@d7ee75a...ac41376

2023-08-08 [email protected] Roll Flutter from ad0aa8d to 436df69 (17 revisions) (flutter/packages#4663)
2023-08-08 [email protected] [webview_flutter_wkwebview] Repeatedly pump WebViews until one is garbage collected (flutter/packages#4662)
2023-08-08 [email protected] [xdg_directories] Add example app (flutter/packages#4554)
2023-08-08 [email protected] [pigeon] Recursively create output target files (flutter/packages#4458)
2023-08-07 [email protected] [path_provider] Add getApplicationCachePath() (flutter/packages#4483)
2023-08-07 [email protected] [flutter_markdown] Adopt code excerpts in README (flutter/packages#4656)
2023-08-07 [email protected] [All] Expand artifact hub to all plugins (flutter/packages#4645)
2023-08-07 [email protected] Roll Flutter from 2ba9f7b to ad0aa8d (31 revisions) (flutter/packages#4659)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: xdg_directories platform-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[xdg_directories] Add example app
3 participants