Skip to content

[webview_flutter_wkwebview] NSError.toString #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

[webview_flutter_wkwebview] NSError.toString #4441

merged 1 commit into from
Jul 11, 2023

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 11, 2023

Fixes flutter/flutter#128596

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@Hixie Hixie requested a review from cyanglaz as a code owner July 11, 2023 19:06
@Hixie Hixie mentioned this pull request Jul 11, 2023
Closed
11 tasks
cyanglaz
cyanglaz approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2023
@auto-submit auto-submit bot merged commit 1999cdc into flutter:main Jul 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
1999cdc [webview_flutter_wkwebview] NSError.toString (flutter/package…
5d7bd3b 
…s#4441)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
1999cdc [webview_flutter_wkwebview] NSError.toString (flutter/package…
c47f761 
…s#4441)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
Roll Packages from 188a846 to 2508714 (14 revisions) (#130418)
544d30d 
flutter/packages@188a846...2508714

2023-07-12 [email protected] ADD appBarBreakpoint (flutter/packages#4434)
2023-07-12 [email protected] Roll Flutter from 65ff3cb to 3ec96a8 (5 revisions) (flutter/packages#4415)
2023-07-12 [email protected] [image_picker] Roll dependancies to avoid error (flutter/packages#4431)
2023-07-12 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.0.0 to 6.0.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4422)
2023-07-12 [email protected] [file_selector] Avoids using path_provider in web example app. (flutter/packages#4445)
2023-07-12 [email protected] [rfw] Add some more documentation for RFW (flutter/packages#4349)
2023-07-12 [email protected] [ci] Enable LUCI legacy analysis (flutter/packages#4435)
2023-07-11 [email protected] [webview_flutter_wkwebview] NSError.toString (flutter/packages#4441)
2023-07-11 [email protected] [ci] Remove unused Chromium setup (flutter/packages#4437)
2023-07-11 [email protected] [flutter_plugin_tools] Reimplements the excerpt system inline in the tool, rather than relying on a separate package. (flutter/packages#4417)
2023-07-11 [email protected] [ci] Remove webview_flutter implementation opt outs for custom analysis (flutter/packages#4438)
2023-07-11 [email protected] [palette_generator] Add web support to unit tests (flutter/packages#4440)
2023-07-11 [email protected] [tool] Conditionalize color on `stdout` (flutter/packages#4436)
2023-07-11 [email protected] [go_router_builder] Cleans up builder code. (flutter/packages#4356)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@engine-flutter-autoroll @LouiseHsu
Roll Packages from 188a846 to 2508714 (14 revisions) (flutter#130418)
fe35ec4 
flutter/packages@188a846...2508714

2023-07-12 [email protected] ADD appBarBreakpoint (flutter/packages#4434)
2023-07-12 [email protected] Roll Flutter from 65ff3cb to 3ec96a8 (5 revisions) (flutter/packages#4415)
2023-07-12 [email protected] [image_picker] Roll dependancies to avoid error (flutter/packages#4431)
2023-07-12 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.0.0 to 6.0.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4422)
2023-07-12 [email protected] [file_selector] Avoids using path_provider in web example app. (flutter/packages#4445)
2023-07-12 [email protected] [rfw] Add some more documentation for RFW (flutter/packages#4349)
2023-07-12 [email protected] [ci] Enable LUCI legacy analysis (flutter/packages#4435)
2023-07-11 [email protected] [webview_flutter_wkwebview] NSError.toString (flutter/packages#4441)
2023-07-11 [email protected] [ci] Remove unused Chromium setup (flutter/packages#4437)
2023-07-11 [email protected] [flutter_plugin_tools] Reimplements the excerpt system inline in the tool, rather than relying on a separate package. (flutter/packages#4417)
2023-07-11 [email protected] [ci] Remove webview_flutter implementation opt outs for custom analysis (flutter/packages#4438)
2023-07-11 [email protected] [palette_generator] Add web support to unit tests (flutter/packages#4440)
2023-07-11 [email protected] [tool] Conditionalize color on `stdout` (flutter/packages#4436)
2023-07-11 [email protected] [go_router_builder] Cleans up builder code. (flutter/packages#4356)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: webview_flutter platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[webview] Add toString for Dart NSError mirror

2 participants

@Hixie @cyanglaz