[image_picker] Update to 1.0 #4285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin now covers all of our supported platforms, most highly-requested features have been addressed, and the API has been stable for quite some time (in that no breaking changes have been required). Given that, a 1.0 version number reflects the current state of the package than a 0.x version. As part of the breaking change, the `get*` methods that were deprecated several years ago have now been removed.
stuartmorgan-g
commented
Jun 23, 2023
| ## 0.8.9 | ||
|
|
||
| * Adds `getMedia` and `getMultipleMedia` methods. | ||
| * Adds `pickMedia` and `pickMultipleMedia` methods. |
There was a problem hiding this comment.
While I generally don't want us changing old changelogs, I noticed that we forgot to adjust the names for the app-facing package, making this wrong, and it's actively confusing when combined with the discussion of removing get in 1.0.0 so I thought it was worthwhile here.
tarrinneal
approved these changes
Jun 23, 2023
| ## 0.8.9 | ||
|
|
||
| * Adds `getMedia` and `getMultipleMedia` methods. | ||
| * Adds `pickMedia` and `pickMultipleMedia` methods. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 26, 2023
flutter/packages@d041934...6b70804 2023-06-23 [email protected] [go_router] Reduces excessive rebuilds due to inherited look up. (flutter/packages#4227) 2023-06-23 [email protected] [image_picker] Update to 1.0 (flutter/packages#4285) 2023-06-23 [email protected] [tool] Consider comment-only changes to be dev-only (flutter/packages#4279) 2023-06-23 [email protected] [ci] Switch to LUCI for Android build-all (flutter/packages#4274) 2023-06-23 [email protected] [file_selector] Add file group to save return value (flutter/packages#4222) 2023-06-23 [email protected] [go_router] Adds onException to GoRouter constructor. (flutter/packages#4216) 2023-06-23 [email protected] [file_selector] Add file group to save return value - implementations (flutter/packages#4273) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
## Changes This PR listens to the `cancel` event from the `input type=file` used by the web implementation of the image_picker plugin, so apps don't end up endlessly awaiting for a file that will never come **in modern browsers** (Chrome 113, Safari 16.4, or newer). _Same API as #3683 Additionally, this PR: * Removes all code and tests mentioning `PickedFile`. (Deprecated years ago, and unused since #4285) **(Breaking change)** * Updates README to mention `XFile` which is the current return type of the package. * Updates the dependency on `image_picker_platform_interface` to `^2.9.0`. * Implements all non-deprecated methods from the interface, and makes deprecated methods use the fresh ones. * Updates tests. ### Issues * Fixes flutter/flutter#92176 ### Testing * Added integration testing coverage for the 'cancel' event. * Tested manually in Chrome with the example app running on web.
11 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin now covers all of our supported platforms, most highly-requested features have been addressed, and the API has been stable for quite some time (in that no breaking changes have been required). Given that, a 1.0 version number reflects the current state of the package than a 0.x version.
As part of the breaking change, the
get*methods that were deprecated several years ago have now been removed.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).