Skip to content

[tool] Only run unit tests in Chrome for inline web #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 8, 2023
Merged

[tool] Only run unit tests in Chrome for inline web #4153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5e2b05
[ci] Exclude maps unit tests on Windows
stuartmorgan-g Jun 6, 2023
210e1f2
[tool] Only run unit tests in Chrome for inline web
stuartmorgan-g Jun 6, 2023
94492b5
Add unit test
stuartmorgan-g Jun 6, 2023
ecf06e5
Enable multidex in local_auth
stuartmorgan-g Jun 6, 2023
4674122
Remove illegal character from test
stuartmorgan-g Jun 6, 2023
adbb685
Merge branch 'main' into tooling-unit-test-web-inline-only
stuartmorgan-g Jun 6, 2023
f454adb
Re-remove google_maps_flutter from exceptions
stuartmorgan-g Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/video_player/video_player/test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,12 +350,12 @@ void main() {

test('file with special characters', () async {
final VideoPlayerController controller =
VideoPlayerController.file(File('A #1 Hit?.avi'));
VideoPlayerController.file(File('A #1 Hit.avi'));
Copy link
Collaborator Author

@stuartmorgan-g stuartmorgan-g Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out ? is an illegal character in a Windows filename, so this test didn't work on Windows. The test still validates URL escaping without the ? so I just removed it rather than conditionalize by platform.

await controller.initialize();

final String uri = fakeVideoPlayerPlatform.dataSources[0].uri!;
expect(uri.startsWith('file:///'), true, reason: 'Actual string: $uri');
expect(uri.endsWith('/A%20%231%20Hit%3F.avi'), true,
expect(uri.endsWith('/A%20%231%20Hit.avi'), true,
reason: 'Actual string: $uri');
}, skip: kIsWeb /* Web does not support file assets. */);

Expand Down
8 changes: 0 additions & 8 deletions script/configs/windows_unit_tests_exceptions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,12 @@
# Unit tests for plugins that support web currently run in
# Chrome, which isn't currently supported by web infrastructure.
# TODO(ditman): Fix this in the repo tooling.
- camera
- camera_web
- file_selector
- file_selector_web
- google_maps_flutter
- google_maps_flutter_web
- google_sign_in
- google_sign_in_web
- image_picker
- image_picker_for_web
- shared_preferences
- shared_preferences_web
- url_launcher
- url_launcher_web
- video_player
- video_player_web
- webview_flutter_web
4 changes: 3 additions & 1 deletion script/tool/lib/src/test_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ class TestCommand extends PackageLoopingCommand {
'--color',
if (experiment.isNotEmpty) '--enable-experiment=$experiment',
// TODO(ditman): Remove this once all plugins are migrated to 'drive'.
if (pluginSupportsPlatform(platformWeb, package)) '--platform=chrome',
if (pluginSupportsPlatform(platformWeb, package,
requiredMode: PlatformSupport.inline))
'--platform=chrome',
],
workingDir: package.directory,
);
Expand Down
23 changes: 22 additions & 1 deletion script/tool/test/test_command_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import 'mocks.dart';
import 'util.dart';

void main() {
group('$TestCommand', () {
group('TestCommand', () {
late FileSystem fileSystem;
late Platform mockPlatform;
late Directory packagesDir;
Expand Down Expand Up @@ -239,6 +239,27 @@ void main() {
);
});

test('Does not run on Chrome for web endorsements', () async {
final RepositoryPackage plugin = createFakePlugin(
'plugin',
packagesDir,
extraFiles: <String>['test/empty_test.dart'],
platformSupport: <String, PlatformDetails>{
platformWeb: const PlatformDetails(PlatformSupport.federated),
},
);

await runCapturingPrint(runner, <String>['test']);

expect(
processRunner.recordedCalls,
orderedEquals(<ProcessCall>[
ProcessCall(getFlutterCommand(mockPlatform),
const <String>['test', '--color'], plugin.path),
]),
);
});

test('enable-experiment flag', () async {
final RepositoryPackage plugin = createFakePlugin('a', packagesDir,
extraFiles: <String>['test/empty_test.dart']);
Expand Down