Skip to content

[ci] Add LUCI repo tool tests #3964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2023
Merged

[ci] Add LUCI repo tool tests #3964

merged 2 commits into from
May 12, 2023

Conversation

stuartmorgan-g
Copy link
Collaborator

  • Adds a LUCI version of the Linux repo tools test, as a first test of a Linux repository test being migrated to LUCI.
  • Fixes the Windows repo tools test to actually run a test, which it wasn't due to a mistaken duplicate yaml file, only one of which was correct (the one that wasn't being used).

@stuartmorgan-g
[ci] Add LUCI repo tool tests
1924d23 
- Adds a LUCI version of the Linux repo tools test, as a first test of a
  Linux repository test being migrated to LUCI.
- Fixes the Windows repo tools test to actually run a test, which it
  wasn't due to a mistaken duplicate yaml file, only one of which was
  correct (the one that wasn't being used).
@stuartmorgan-g
Add missing mock platform to fix Windows
3a6e731
keyonghan
keyonghan reviewed May 12, 2023
View reviewed changes
.ci.yaml
targets:
### iOS+macOS tasks ***
### Linux tasks ###
- name: Linux repo_tools_tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test need the docker image support?
/cc @yusuf-goog who is helping with general docker support for vm based builds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not expect it to.

Per this comment, I'm not convinced we need docker support at all for this repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This test is literally just running dart test in a directory, so if we need Docker for this something is wrong.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Then the Linux migration should be unblocked! /cc @yusuf-goog who is also helping with remaining packages Linux tasks migration to LUCI.

One thing to check is whether this test needs any dependencies. Now the linux platform only enforces the os dimension os: Linux. An LED run may give you some signal. This is the doc how to test a new builder: go/flutter-luci-recipes#testing-a-local-change-for-a-new-builderrecipe. For this case specifically, you can use Windows repo_tools_tests, and change the os to Linux.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/stuartmorgan_google.com/b340388546ffb86941a2a5b4307cf8c79adbc9436acda46dc29f0a7b72a1068c/+/build.proto?server=chromium-swarm.appspot.com

keyonghan
keyonghan approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit auto-submit bot merged commit a2aac12 into flutter:main May 12, 2023
@stuartmorgan-g stuartmorgan-g deleted the ci-linux-luci-initial branch May 13, 2023 14:41
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 13, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a2aac12 [ci] Add LUCI repo tool tests (flutter/packages#3964)
89d644d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a2aac12 [ci] Add LUCI repo tool tests (flutter/packages#3964)
ce65c96
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
a2aac12 [ci] Add LUCI repo tool tests (flutter/packages#3964)
51775d5
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 15, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (#126865)
96580f5 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 6328cfb to 6608b60 (22 revisions) (flutter#126865)
e39437c 
flutter/packages@6328cfb...6608b60

2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975)
2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979)
2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980)
2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964)
2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973)
2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972)
2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958)
2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887)
2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967)
2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955)
2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960)
2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959)
2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963)
2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965)
2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784)
2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969)
2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970)
2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877)
2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962)
2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961)
2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423)
2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[ci] Add LUCI repo tool tests (flutter#3964)
5961753 
- Adds a LUCI version of the Linux repo tools test, as a first test of a Linux repository test being migrated to LUCI.
- Fixes the Windows repo tools test to actually run a test, which it wasn't due to a mistaken duplicate yaml file, only one of which was correct (the one that wasn't being used).
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartmorgan-g @keyonghan