[various] Clarify endorsement in READMEs #3404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested review from
LouiseHsu,
bparrishMines,
camsim99,
cbracken,
cyanglaz,
ditman,
gmackall,
hellohuanlin,
jmagman,
reidbaker and
vashworth
as code owners
github-actions
bot
added
p: camera
p: file_selector
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
p: shared_preferences
p: url_launcher
p: video_player
p: webview_flutter
platform-android
platform-ios
platform-linux
labels
jmagman
approved these changes
Mar 7, 2023
cbracken
approved these changes
Mar 7, 2023
ditman
approved these changes
Mar 7, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Ship it! I also like the explanation on not endorsed packages!
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 3404, due to - The status or check suite web-platform_tests CHANNEL:stable PACKAGE_SHARDING:--shardIndex 1 --shardCount 2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 3404, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[various] Clarify endorsement in READMEs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the boilerplate text about endorsement in the implementation package READMEs to avoid confusion. There are cases where clients may use the implementation packages directly (most often, to call platform-specific extensions), and the old text was leading some people to believe they shouldn't depend on the package when they did so. This clarifies that while the common use case of indirect usage doesn't require a dependency, direct usage does.
Fixes flutter/flutter#121757
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).