[in_app_purchase] Enable -Werror for Android #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
added
override: no versioning needed
Collaborator
Author
|
Overriding version/changelog: the non-test-file changes are exclusively:
both of which are dev-only changes, thus exempt by policy even though the tooling can't detect that. |
stuartmorgan-g
commented
Mar 7, 2023
| private HashMap<String, SkuDetails> cachedSkus = new HashMap<>(); | ||
| // TODO(stuartmorgan): Migrate this code. See TODO on querySkuDetailsAsync. | ||
| @SuppressWarnings("deprecation") | ||
| private HashMap<String, com.android.billingclient.api.SkuDetails> cachedSkus = new HashMap<>(); |
Collaborator
Author
There was a problem hiding this comment.
Having to inline namespaces everywhere is the most annoying part of the change, but having -Werror is more important IMO. And all of this will go away when the code is migrated to v5.
Collaborator
Author
There was a problem hiding this comment.
v5 of the Google Play Billing Library, which this plugin wraps.
reidbaker
approved these changes
Mar 8, 2023
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 9, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[in_app_purchase] Enable -Werror for Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
-Werrorflag on the Java compilation step, fixing and suppressing the existing issues.Unlike most other packages where we've enabled this, this consists almost entirely of sweeping suppressions (specifically,
deprecation), since the package was updated to the v5 billing library but still uses many APIs from v4 that are deprecated in v5. While this is more suppression than we would normally want to do, it still sets us up to catch other kinds of warnings going forward. It may also help when the full migration to v5 API is done, since just removing the deprecation suppressions will make it easy to find all of the code than needs to be updated. Given that, I believe this is still a net improvement over having-Werroroff.Part of flutter/flutter#91868
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).