-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[in_app_purchase] Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE
#3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in_app_purchase] Prepare for NULLABLE_ARGUMENT_TO_NON_NULL_TYPE
#3275
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
The false positive linter error is fixed in Dart |
test-exempt: fixing lint This is going to be tricky to land though because it has to be lint-free on both the main branch and the last stable. Search for |
packages/in_app_purchase/in_app_purchase_storekit/test/fakes/fake_storekit_platform.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment wording
# Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
@bparrishMines or @tarrinneal could you do the second review here? |
…lutter#3275) [in_app_purchase] Prepare for `NULLABLE_ARGUMENT_TO_NON_NULL_TYPE`
flutter/flutter#121318
This PR modifies the code in order not to trigger the incoming diagnostic.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.